change find_ids_across_trees to return None when asked to find ids for ['']
Bug #86940 reported by
Robert Collins
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Medium
|
Unassigned |
Bug Description
find_ids_
asked to find ids for the path ['']. This results in double handling of
id data when we dont need to.
find_ids_
['']: but this will require changing code that currently does not handle
None in this case.
-Rob
affects /products/bzr
status confirmed
importance medium
--
GPG key available at: <http://
tags: | added: api |
tags: | added: check-for-breezy |
tags: | removed: check-for-breezy |
To post a comment you must log in.
I think this is totally bogus. find_ids_ across_ trees should only return None if its input is None.
Functions and methods that get an empty list should treat it as an empty list. I think you want to treat user input of the empty list as meaning wildcard, but that should be done as part of user input parsing, and perhaps not in all cases.
Treating [] differently from all other lists is a bogosity that does not belong in the Bazaar API, e.g. WT.revert