Change to tilde escaping causes test failures
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
Martin Packman |
Bug Description
In r6079 url handling was changed to start escaping tildes to %7E, which was noted as suboptimal in review:
<https:/
However it also causes some pretty serious fallout in the test suite if the paths used contain tildes, as happens on the windows babune slave which uses the short name version for its temp directory. For instance:
Traceback (most recent call last):
File "c:\cygwin\
self.
AssertionError: not equal:
a = 'sftp://
b = 'sftp://
The fact transport base urls are inconsistenly escaped also confused the test isolation checks leading to failures like:
BzrError: Attempt to escape test isolation: 'sftp://
There is no reason to escape tildes, and not being consistent about escaping is dangerous.
Related branches
- Martin Pool: Approve
- Jelmer Vernooij (community): Approve
-
Diff: 85 lines (+29/-3)4 files modifiedbzrlib/tests/per_transport.py (+22/-0)
bzrlib/tests/test_smart_transport.py (+1/-1)
bzrlib/urlutils.py (+3/-2)
doc/en/release-notes/bzr-2.5.txt (+3/-0)
Changed in bzr: | |
importance: | Undecided → Medium |
status: | New → Confirmed |
Changed in bzr: | |
assignee: | nobody → Martin Packman (gz) |
importance: | Medium → High |
status: | Confirmed → In Progress |
Changed in bzr: | |
milestone: | none → 2.5b4 |
status: | In Progress → Fix Released |
On 06/09/11 01:19, Martin [gz] wrote: /code.launchpad .net/~jelmer/ bzr/transport- segments/ +merge/ 71583>
> Public bug reported:
>
> In r6079 url handling was changed to start escaping tildes to %7E, which
> was noted as suboptimal in review:
>
> <https:/
Please note that the issue that was pointed out by the reviewer is
already fixed in bzr.dev, and is different from what you're pointing out
here. That was about displaying "locations", which is different from the
representation we use internally anyway.
Cheers,
Jelmer