test_osutils fails because /dev/null may be a symlink
Bug #832257 reported by
Igor Pashev
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Medium
|
Unassigned | ||
Breezy |
Fix Released
|
Medium
|
Jelmer Vernooij |
Bug Description
test_osutils.py check whether /dev/null is a character device, but /dev/null can be a symlink [to character device] as in Illumos (aka OpenSolaris).
http://
Related branches
lp://staging/~jelmer/brz/symlink-dev-null
Merged
into
lp://staging/brz
- Martin Packman: Approve
-
Diff: 27 lines (+5/-1)2 files modifiedbreezy/tests/test_osutils.py (+3/-1)
doc/en/release-notes/brz-3.0.txt (+2/-0)
tags: | added: check-for-breezy |
Changed in bzr: | |
status: | Confirmed → Fix Committed |
status: | Fix Committed → Confirmed |
Changed in brz: | |
status: | New → Fix Committed |
importance: | Undecided → Medium |
tags: | removed: check-for-breezy |
Changed in brz: | |
status: | Fix Committed → Fix Released |
assignee: | nobody → Jelmer Vernooij (jelmer) |
milestone: | none → 3.0.0 |
To post a comment you must log in.
Thanks, I think that accounts for a previously known failure.
This test wants to examine something that is not a regular file, directory, or symlink. Of course we can't create device nodes from a non-root test.
What should we do?
- skip this test if /dev/null is a symlink? the test is not super important but this report shows it's good to catch portability bugs.
- assert there is at least one device file in /dev?
- if /dev/null is a symlink, follow it, and check the ultimate target is a device
I think I like the last best. If you want to try a patch, please do.