CommitBuilder.record_entry_contents needs to die

Bug #731433 reported by Jelmer Vernooij
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released
Jelmer Vernooij

Bug Description

CommitBuilder currently provides two interfaces to record tree changes, both of which are used by bzrlib.commit depending on the situation.

CommitBuilder.record_iter_changes() is the newer one, and should ideally completely replace CommitBuilder.record_entry_contents().

Having two implementations is problematic since it makes requires duplicate effort for every CommitBuilder implementation and makes it harder to write tests.

Tags: commit

Related branches

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This has been partially resolved now that record_entry_contents is optional (CommitBuilders can choose to not support it).

Changed in bzr:
importance: High → Low
status: In Progress → Confirmed
assignee: Jelmer Vernooij (jelmer) → nobody
Jelmer Vernooij (jelmer)
tags: removed: foreign
Jelmer Vernooij (jelmer)
Changed in brz:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Jelmer Vernooij (jelmer)
milestone: none → 3.0.0
Jelmer Vernooij (jelmer)
Changed in brz:
status: Triaged → In Progress
Jelmer Vernooij (jelmer)
Changed in brz:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.