Bazaar

In-terminal crash report is far too long, containing full `bzr plugins` output

Bug #716389 reported by Max Bowsher on 2011-02-10

This bug affects 3 people

	Status	Importance	Assigned to	Milestone
Bazaar	Fix Released	Medium	Martin Pool	Bazaar 2.3.2
bzr (Ubuntu)	Fix Released	Medium	Unassigned
Natty	Fix Released	Medium	Jelmer Vernooij

Bug Description

Recently there was a change to including the full list of plugins, in `bzr plugins` style in the non-apport crash reporting output. (To see what I mean, run 'bzr assert-fail' using bzr.dev)

This is most unhelpful, because it is very long indeed, and causes the traceback and exception message to scroll completely off the screen - in my environment `bzr plugins` is 87 lines long.

I propose that it is important for developers that when an exception occurs, the exception message line remains on screen in reasonably sized terminals.

What was the intent of adding the full plugin list? Some discussion on #bzr suggests that what was actually desired was a list of plugins currently violating their API requirements.

Tags:

Related branches

lp://staging/~mbp/bzr/error-reporting

Merged into lp://staging/bzr/2.3 at revision 5635

Martin Packman (community): Approve on 2011-04-01

Superseded for merging into lp://staging/bzr

John A Meinel: Approve on 2011-03-31

lp://staging/ubuntu/natty-proposed/bzr

Revision history for this message

Vincent Ladeuil (vila) wrote on 2011-02-10:

120 lines here, 4 lines by plugin as in `bzr plugins -v`.

'-v' makes sense to identify faulty plugins, but please, let's display only the ones potentially violating the API requirements.

Changed in bzr:
status:	New → Confirmed

Revision history for this message

Martin Pool (mbp) wrote on 2011-02-14:

> Some discussion on #bzr suggests that what was actually desired was a list of plugins currently violating their API requirements.

Right.

I agree showing only the failing plugins, if that, would be better.

@vila, maxb, please set both the status and importance.

Changed in bzr:
importance:	Undecided → Medium
tags:	added: easy error-reporting plugins

Martin Pool (mbp) on 2011-03-28

Changed in bzr:
assignee:	nobody → Martin Pool (mbp)
status:	Confirmed → In Progress

Vincent Ladeuil (vila) on 2011-04-11

Changed in bzr:
milestone:	none → 2.3.2
status:	In Progress → Fix Released

Jelmer Vernooij (jelmer) on 2011-06-08

Changed in bzr (Ubuntu):
status:	New → Fix Released
importance:	Undecided → Medium
Changed in bzr (Ubuntu Natty):
status:	New → In Progress
importance:	Undecided → Medium

Jelmer Vernooij (jelmer) on 2011-06-10

Changed in bzr (Ubuntu Natty):
assignee:	nobody → Jelmer Vernooij (jelmer)

Revision history for this message

Martin Pitt (pitti) wrote on 2011-06-17: Please test proposed package

Accepted bzr into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in bzr (Ubuntu Natty):
status:	In Progress → Fix Committed
tags:	added: verification-needed

Revision history for this message

Clint Byrum (clint-fewbar) wrote on 2011-07-19:

Hello Max, or anyone else affected,

Revision history for this message

Jelmer Vernooij (jelmer) wrote on 2011-07-22:

Verified by running the bzr testsuite from the package in a clean natty install.

tags:	added: verification-done removed: verification-needed
tags:	added: verification-needed removed: verification-done

Jelmer Vernooij (jelmer) on 2011-07-22

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2011-08-01:

This bug was fixed in the package bzr - 2.3.4-0ubuntu1

---------------
bzr (2.3.4-0ubuntu1) natty-proposed; urgency=low

  * New upstream release.
   + Fix bzr version number in deprecation warnings. LP: #794960
   + Prevent write attemps on remote branch during "bzr up". LP: #786980
   + Fix conflict handling when two trees involved in a merge have different
     root ids. LP: #805809

bzr (2.3.3-0ubuntu1) natty-proposed; urgency=low

  * New upstream release.
   + Fixes deprecation warning on newer versions of Python. LP: #760435
   + Stops 'bzr push' from copying entire repository if a .bzr directory is
     present without a branch. LP: #465517
   + Fixes undefined local variable error when waiting for lock. LP: #733136
   + Fixes lock contention issues pushing to a bound branch. LP: #733350
   + Transfers less data creating a new stacked branch. LP: #737234
   + Several fixes to the test suite, making it more robust. LP: #654733,
      LP: #751824
   + 'bzr merge --pull --preview' actually shows a preview rather than
     actually merging. LP: #760152
   + bzr smart server now supports UTF-8 user names. LP: #659763
   + user identity can now be set based on username and /etc/mailname, not
     requiring it to be set manually. LP: #616878
   + stacking is now fully transitive. LP: #715000
   + makes in-terminal crash report of plugins much shorter. LP: #716389
-- Jelmer Vernooij <email address hidden> Thu, 14 Jul 2011 21:12:58 +0200

Changed in bzr (Ubuntu Natty):
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

Duplicates of this bug

Bug #776272

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.