change_editor syntax is unique
Bug #708718 reported by
John A Meinel
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Confirmed
|
Low
|
Unassigned | ||
| Breezy |
Fix Released
|
Low
|
Jelmer Vernooij | ||
Bug Description
The change editor takes a syntax of "command @old_path @new_path" using "@old_path" to define where to put the given parameter.
I don't think this matches what we have for external diff commands, and mergetools, etc. I think the standard there is {old_path} {new_path}, but I'm not positive.
Related branches
lp://staging/~jelmer/brz/change-editor-consistent
- Martin Packman: Approve
-
Diff: 275 lines (+58/-33)6 files modifiedbreezy/builtins.py (+3/-3)
breezy/config.py (+7/-1)
breezy/diff.py (+2/-13)
breezy/tests/test_config.py (+26/-4)
breezy/tests/test_diff.py (+14/-12)
doc/en/release-notes/brz-3.1.txt (+6/-0)
| tags: | added: check-for-breezy |
| tags: | removed: check-for-breezy |
| Changed in brz: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| Changed in brz: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
| milestone: | none → 3.1.0 |
| Changed in brz: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
We aim at using the {option} syntax, but we aren't there yet, the change_editor use is on my radar though