Bazaar

bzr whoami shouldn't allow empty ("") argument

Bug #674836 reported by Alexander Belchenko
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
High
Unassigned
Breezy
Triaged
Low
Unassigned

Bug Description

bzr 2.2.1:

C:\work\>bzr whoami --branch ""
"" does not seem to contain an email address. This is allowed, but not recommended.

C:\work\>bzr whoami
bzr: ERROR: Unable to determine your name.
Please, set your name with the 'whoami' command.
E.g. bzr whoami "Your Name <email address hidden>"

I don't think it's a good behavior.

Tags: whoami
Revision history for this message
Marius Kruger (amanica) wrote :

Why do you thing its bad?
What should it do?

Revision history for this message
Alexander Belchenko (bialix) wrote : Re: [Bug 674836] Re: bzr whoami shouldn't allow empty ("") argument

Marius Kruger пишет:
> Why do you thing its bad?
> What should it do?

I think bzr shouldn't allow `bzr whoami ""` to succeed and set "" as
identity value, because it's obvious that next time user will get
NoWhoAmi error on commit or some other operations.

--
All the dude wanted was his rug back

Revision history for this message
Vincent Ladeuil (vila) wrote :

+1 '' or None leads to the same results so they should be handled the same.

But also note that there have been discussions about *forcing* a valid whoami being a bad thing too...

Changed in bzr:
status: New → Confirmed
importance: Undecided → High
Jelmer Vernooij (jelmer)
tags: added: whoami
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
Changed in brz:
status: New → Triaged
importance: Undecided → Low
tags: removed: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.