http clients repeatedly read the tags file
Bug #567619 reported by
Martin Pool
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Low
|
Unassigned |
Bug Description
In looking at the Launchpad codehost logs, it seems that bzr http dumb clients reading the tags file unreasonably often. (Sorry, I'm not sure yet what operation is doing this, but spm can provide anonymized logs.)
tags: | added: check-for-breezy |
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Martin Pool wrote:
> Public bug reported:
>
> In looking at the Launchpad codehost logs, it seems that bzr http dumb
> clients reading the tags file unreasonably often. (Sorry, I'm not sure
> yet what operation is doing this, but spm can provide anonymized logs.)
>
> ** Affects: bzr
> Importance: Low
> Status: Confirmed
>
>
> ** Tags: http performance
>
Bzr doesn't cache the tags field. I worked around this in loggerhead in
a recent patch. On trunk:
413 John Arbash Meinel 2010-04-27 [merge]
Cache the Branch reverse-tag dict, since Branch does not.
We don't cache the result of "Branch. tags.get_ tag_dict( )" nor tags.get_ reverse_ tag_dict( )". So we have to read and deserialize
"Branch.
the tags file each time.
In the case of loggerhead, this was being done for each revision that
was being displayed (so that it could add the tags info if present).
John
=:->
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org/
ZJG4ACgkQJdeBCY SNAAMbbwCcCZxEo 3UvWgPw1+ omlSqQ0KdK g1uLjBiJeIIVbJq 6O+Yf7
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkv
rtsAnAhtbL/
=JcZE
-----END PGP SIGNATURE-----