missing features about format deprecation

Bug #497694 reported by Vincent Ladeuil
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Medium
Unassigned
Breezy
Triaged
Medium
Unassigned

Bug Description

The following points were raised during https://code.launchpad.net/~vila/bzr/deprecation-warning-preference/+merge/16233

- the actual implementation use a single global variable for the whole code base,
  forget about being warned for the second repo accessed (or the 20th for bzrlib users),
  that should be implemented as a repo attribute instead,
- working trees can raise format deprecation warnings too, they should use the new
  facility (I don't think we want to proliferate warning variables gratuitously)
- hpss remote repositories don't raise the warning locally (AFAICS but feel free
  to prove me wrong),
- no distinction is made between read and write access (I'm not sure I understand
  the need here),
- there is no config file for repositories were such an option can be specified.

Vincent Ladeuil (vila)
Changed in bzr:
status: New → Confirmed
importance: Undecided → Medium
Vincent Ladeuil (vila)
description: updated
Revision history for this message
Matt Nordhoff (mnordhoff) wrote :

Since bzr more or less always winds up making VFS requests when using the hpss, you still get the warning when that happens. Whether that was intended, I don't know.

Revision history for this message
Marius Kruger (amanica) wrote :

I may have mentioned it before, I think it could be a service which is provided by trace.py
Make a log level for annoying warning messages, so that this sort of functionality can be reused without much effort.
Callers can use it like:
trace.nag("deprecation_warnings", "Such and such is deprecated")
trace.nag("old_format", "You should upgrade your branch")

If the message is printed it should explain (or point you to a topic which explains)
how to disable a certain class of annoying error messages (by adding the class eg. "deprecation_warnings" somewhere in the config file).

my 2c

Jelmer Vernooij (jelmer)
tags: added: config format-infrastructure formats
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
tags: removed: check-for-breezy
Changed in brz:
status: New → Triaged
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.