RemoteStream.get_stream_for_missing_keys uses VFS

Bug #495979 reported by John A Meinel
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released
Jelmer Vernooij

Bug Description

Because of bug #495977, this will be a bit brief (the +filebug page resets on
me every 30s or so... :(

Basically, because RemoteStream.get_stream_for_missing_keys doesn't have an
RPC, when you branch a project with ghosts (like bzr and launchpad), it ends up
calling _ensure_real, then trying reading the .rix and .iix to determine that
those revisions really are ghosts.

I don't know the specific performance implication, because btree indexes mean
that while we have to read every index, we don't have to real all of each one.
However, it does end up being quite a few round-trips to find out that
everything really isn't there. (local and dumb fetches don't have this problem
as they've already had to read the index to determine what to fetch in the
first place.)

Related branches

Jelmer Vernooij (jelmer)
tags: added: hpss-no-vfs
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
tags: removed: check-for-breezy
Changed in brz:
status: New → Triaged
importance: Undecided → Medium
Jelmer Vernooij (jelmer)
Changed in brz:
assignee: nobody → Jelmer Vernooij (jelmer)
Jelmer Vernooij (jelmer)
Changed in brz:
status: Triaged → In Progress
Jelmer Vernooij (jelmer)
Changed in brz:
milestone: none → 3.0.0
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.