branching from a 1.14 branch creates a wt4 tree, therefore content filtering doesn't work

Bug #414305 reported by Martin Pool
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Medium
Unassigned

Bug Description

Hi

I'm working on the Xibo project which is hosted in Launchpad (https://code.launchpad.net/xibo).

The development work is done cross-platform so we're constantly having problems with line endings, both when building release files and when looking at diffs.

We want to upgrade all the development team to using the 1.14 format so that we can use the line endings conversion tool. I've written up a rules file and put it in my .bazaar folder. You can see a copy I've checked in to the repo here for the other devs to use:
http://bazaar.launchpad.net/~alexharrington/xibo/line-end-test/annotate/head%3A/rules

Next I branched lp:xibo/1.0, fixed up all the line endings so that the use Unix style, and committed the changes. I then did bzr upgrade --1.14 to pull the branch up to working format 5 as per the documentation. I then pushed that up to lp:~alexharrington/xibo/line-end-test

If I now branch that on a Windows PC using 1.17 with the same rules file in %APPDATA%/Bazaar/2.0/rules I don't seem to get the line end conversion, and if I do bzr info -v, I see it's using working format 4 again.

What sequence of events do I need to go through to convert lp:xibo/1.0 to the new format, so that the developers branching that will use the new format, and hence loose the line endings issues we've had till now?

Cheers

Alex

Revision history for this message
Martin Pool (mbp) wrote :

I haven't gone through the reproduction steps but I think what's happening is that, because there's no wt in the source, we create the default format (or the default for this bzrdir) in the destination therefore it doesn't work.

One unattractive workaround is to upgrade the working tree after getting it.

It would probably also work to upgrade the hosted branch to 2a; this requires everyone be using 1.17 or preferable 1.18rc1.

I think there's still some kind of general bug here in how we choose the format; it should probably be determined by the branch and repo.

Changed in bzr:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 414305] Re: branching from a 1.14 branch creates a wt4 tree, therefore content filtering doesn't work

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> I haven't gone through the reproduction steps but I think what's
> happening is that, because there's no wt in the source, we create the
> default format (or the default for this bzrdir) in the destination
> therefore it doesn't work.
>
> One unattractive workaround is to upgrade the working tree after getting
> it.
>
> It would probably also work to upgrade the hosted branch to 2a; this
> requires everyone be using 1.17 or preferable 1.18rc1.
>
> I think there's still some kind of general bug here in how we choose the
> format; it should probably be determined by the branch and repo.
>

So the issue is that the branch and repository format for 1.9 are
identical to 1.14. The only difference is the WT format. Since there is
no WT, we can't detect that the source is 1.14.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqHjWsACgkQJdeBCYSNAAN+aQCcCwf86wwT5+FNcOcSRtDAqcB5
b5cAn2lhOmLwStfuaUQEDOl+9DP4oLw3
=crx1
-----END PGP SIGNATURE-----

Revision history for this message
Martin Pool (mbp) wrote :

Right, so I don't think we can fix this bug in isolation, but we could do something better about overall format combinations.

Jelmer Vernooij (jelmer)
tags: added: content-filtering format-infrastructure formats
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.