On Wed, 2006-10-18 at 05:20 +0000, Martin Pool wrote:
> On 18 Oct 2006, Richard Wilbur <email address hidden> wrote:
> > John, Martin, et al:
> >
> > I'd like to propose some changes in the user interface for ignore:
> >
> > These changes fell naturally out of fixing bug 3780. The test cases are
> > already written and no new regressions noted.
>
> So just to be clear, the *changes* from the current behaviour would be:
>
> * 'bzr ignore' shows the path of the relevant ignore file.
> (OK)
>
> * 'bzr ignore' with no arguments shows the list of ignore patterns?
> (I'm not so sure about this, though it could be OK under an
> option.)
These first two *changes* amount to a correct interpretation of the
first use case where Mary types only 'bzr ignore'.
If the list of ignore patterns requires an option, what would you
suggest? '-l, --list'?
> * bzr ignore with absolute paths turns them into branch-root-relative
> relative paths before adding them (also reasonable, matches what we
> do with other commands.)
This is also correct for Jules' test cases (the second and third). He
can paste a filename or a path and add wildcards. Some software
projects have very long paths, and in this case select and paste saves a
lot of typing--and misspelling. The idea is that, as long as the path
is in the branch, the absolute path in the pattern will be processed
into a branch-root-relative path as if you had taken the care to
properly trim it.
This works hand-in-hand with the changes required by bug 3780 (to add
branch-root-relative paths to a pattern), but more like the
contrapositive.
>
> I'll watch out for the test cases.
The initial patch (containing test cases) is attached to the bug. I
wanted to nail down the specification before sending it on to the
mailing list.
> --
> Martin
>
On Wed, 2006-10-18 at 05:20 +0000, Martin Pool wrote:
> On 18 Oct 2006, Richard Wilbur <email address hidden> wrote:
> > John, Martin, et al:
> >
> > I'd like to propose some changes in the user interface for ignore:
> >
> > These changes fell naturally out of fixing bug 3780. The test cases are
> > already written and no new regressions noted.
>
> So just to be clear, the *changes* from the current behaviour would be:
>
> * 'bzr ignore' shows the path of the relevant ignore file.
> (OK)
>
> * 'bzr ignore' with no arguments shows the list of ignore patterns?
> (I'm not so sure about this, though it could be OK under an
> option.)
These first two *changes* amount to a correct interpretation of the
first use case where Mary types only 'bzr ignore'.
If the list of ignore patterns requires an option, what would you
suggest? '-l, --list'?
> * bzr ignore with absolute paths turns them into branch- root-relative root-relative path as if you had taken the care to
> relative paths before adding them (also reasonable, matches what we
> do with other commands.)
This is also correct for Jules' test cases (the second and third). He
can paste a filename or a path and add wildcards. Some software
projects have very long paths, and in this case select and paste saves a
lot of typing--and misspelling. The idea is that, as long as the path
is in the branch, the absolute path in the pattern will be processed
into a branch-
properly trim it.
This works hand-in-hand with the changes required by bug 3780 (to add root-relative paths to a pattern), but more like the
branch-
contrapositive.
>
> I'll watch out for the test cases.
The initial patch (containing test cases) is attached to the bug. I
wanted to nail down the specification before sending it on to the
mailing list.
> --
> Martin
>