editor email client should support signing merge directives

This primarily effects people who have to use 'mail_client=editor' I guess, which is a huge percentage of users given the popularity of web based clients.

The email itself needs to be signed, not the merge proposal, and thats outside of bzr's control.

If bzr isn't assembling and sending the email, what is?

On Fri, 03 Apr 2009 17:33:41 Stuart Bishop wrote:
> ** Description changed:
>
> We previously used bzr send or bzr send --no-bundle to request reviews.
>
> - These requests are now being bounced because they are not GPG signed.
> + For users using mail_client=editor, these requests are now being bounced
> + because they are not GPG signed.
> +
> + bzr needs to gpg sign the email before sending or launchpad needs to
> + allow non-gpg signed requests.
> +
> + I estimate this affects approximately 50% of Launchpad users. I'm not
> + sure of the percentage of Launchpad Code Hosting users.

Launchpad will no longer accept unsigned merge directives. Launchpad will be
creating branches based on the merge directives, and the emails must be
signed.

bzr is assembling and sending the email, so the won't fix rationale is incorrect.

On Fri, 2009-04-03 at 09:52 +0000, Stuart Bishop wrote:
> bzr is assembling and sending the email, so the won't fix rationale is
> incorrect.

bzr hands off to your email client, its up to the mail client to sign
it.

-Rob

On Fri, 2009-04-03 at 11:04 +0000, Robert Collins wrote:
> On Fri, 2009-04-03 at 09:52 +0000, Stuart Bishop wrote:
> > bzr is assembling and sending the email, so the won't fix rationale is
> > incorrect.
>
> bzr hands off to your email client, its up to the mail client to sign
> it.

Except in the case of "mail_client = editor", where bzr gives you an
editor and then sends the mail for you, doesn't it?

In that case it would be possible to sign it. However, I'm not sure that
we would be able to instruct many mail clients to sign the message using
the interfaces that we have, which would be nice if we add "--sign" to
send to support this.

Thanks,

James