Stacked-on branch not unlocked when commit_write_group fails on stacked branch
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Low
|
Unassigned |
Bug Description
When Repository.
This was seen when the failure:
Module XXX, line YYY, in ZZZ
branch.
Module <string>, line 4, in pull_write_locked
Module bzrlib.branch, line 1931, in pull
_override_
Module <string>, line 4, in pull_write_locked
Module bzrlib.branch, line 1736, in pull
graph=graph)
Module <string>, line 4, in update_
Module bzrlib.branch, line 517, in update_revisions
self.
Module <string>, line 4, in fetch_write_locked
Module bzrlib.branch, line 279, in fetch
pb=nested_pb)
Module bzrlib.repository, line 975, in fetch
find_
Module <string>, line 4, in fetch_write_locked
Module bzrlib.repository, line 2762, in fetch
pb, find_ghosts)
Module bzrlib.fetch, line 115, in __init__
self.
Module bzrlib.repository, line 942, in commit_write_group
self.
Module bzrlib.
return self._pack_
Module bzrlib.
if not self.autopack():
Module bzrlib.
self.
Module bzrlib.
_packer_
Module bzrlib.
return self._create_
Module bzrlib.
self.
Module bzrlib.
missing_
RevisionNotPresent: Revision {<email address hidden>} not present in "source-
Caused the following warning:
bzrlib/
warnings.warn("%r was gc'd while locked" % self)
lifeless has provided the following patch:
=== modified file 'bzrlib/
--- bzrlib/
+++ bzrlib/
@@ -1027,9 +1027,12 @@
if self._write_group is not None:
- self.control_
+ self._unlock()
+ self._unlock()
+
+ def _unlock(self):
for repo in self._fallback_
Related branches
tags: |
added: stacking removed: stack |
Changed in bzr: | |
status: | Confirmed → In Progress |
assignee: | nobody → Martin Pool (mbp) |
Changed in bzr: | |
assignee: | Martin Pool (mbp) → nobody |
importance: | Medium → Low |
status: | In Progress → Confirmed |
tags: | added: check-for-breezy |
The patch looks reasonable to me.