Hookable error logging for smart servers
Bug #274578 reported by
Michael Hudson-Doyle
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Fix Released
|
High
|
Jonathan Riddell | ||
| Launchpad itself |
Triaged
|
High
|
Unassigned | ||
Bug Description
If something unexpected happens in the 'bzr lp-serve' process we spawn on a bzr+ssh connection, we don't find out about it (well, we probably get a report that a subprocess exited with code 1 in our logs). The unlucky user probably gets a traceback in their terminal.
We should log an oops.
I think we can probably do this in sys.excepthook.
Related branches
lp://staging/~jr/bzr/274578-smart-server-hookable-error-logging
- Vincent Ladeuil: Needs Fixing
-
Diff: 94 lines (+35/-4)3 files modifiedbzrlib/smart/server.py (+12/-3)
bzrlib/tests/blackbox/test_serve.py (+19/-1)
doc/en/release-notes/bzr-2.4.txt (+4/-0)
Revision history for this message
| Jonathan Lange (jml) wrote | #1 |
| Changed in launchpad-bazaar: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| tags: | added: codehosting-ssh |
| Changed in launchpad-code: | |
| assignee: | nobody → Jonathan Lange (jml) |
| status: | Triaged → In Progress |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Jonathan Lange (jml) wrote | #2 |
| Changed in launchpad-code: | |
| status: | Fix Committed → In Progress |
| milestone: | none → 2.2.9 |
Revision history for this message
| Jonathan Lange (jml) wrote | #3 |
| Changed in bzr: | |
| assignee: | nobody → Jonathan Lange (jml) |
| importance: | Undecided → Medium |
| status: | New → In Progress |
| summary: |
- tracebacks in lp-serve are not logged anywhere + Hookable error logging for smart servers |
Revision history for this message
| Matthew Revell (matthew.revell) wrote | #4 |
| Changed in launchpad-code: | |
| milestone: | 2.2.9 → 3.0 |
| Changed in bzr: | |
| status: | In Progress → Triaged |
| Changed in launchpad-code: | |
| status: | In Progress → Triaged |
Revision history for this message
| Jonathan Lange (jml) wrote | #5 |
| Changed in bzr: | |
| assignee: | Jonathan Lange (jml) → nobody |
| Changed in launchpad-code: | |
| assignee: | Jonathan Lange (jml) → nobody |
| Changed in launchpad-code: | |
| milestone: | 3.0 → 3.1.10 |
| Changed in launchpad-code: | |
| milestone: | 3.1.10 → none |
| Changed in bzr: | |
| status: | Triaged → Confirmed |
| Changed in bzr: | |
| importance: | Medium → High |
| Changed in bzr: | |
| assignee: | nobody → canonical-bazaar (canonical-bazaar) |
| Changed in bzr: | |
| assignee: | canonical-bazaar (canonical-bazaar) → Jonathan Riddell (jr) |
| Changed in bzr: | |
| status: | Confirmed → In Progress |
| Changed in bzr: | |
| milestone: | none → 2.4b4 |
| status: | In Progress → Fix Released |
| tags: | added: oops-infrastructure |
To post a comment you must log in.
This is really important to fix. We need error reporting.