Bazaar

Inconsistence in use of sys.stdout and self.outf in module bzrlib/builtins.py

Bug #268573 reported by B. Clausius on 2008-09-10

Affects		Status	Importance	Assigned to	Milestone
	Bazaar	Confirmed	Low	Unassigned
	Breezy	Fix Released	Low	Jelmer Vernooij	Breezy 3.0.0 "Pelican"

Bug Description

barcc:~$ bzr version
Bazaar (bzr) 1.6.1
  Python interpreter: /usr/bin/python 2.5.2
  Python standard library: /usr/lib/python2.5
  bzrlib: /usr/lib/python2.5/site-packages/bzrlib

In module bzrlib/builtins some run(...) methods use self.outf others use sys.stdout for writing to.

sys.stdout used in:
    cmd_diff.run()
    cmd_testament.run()
    cmd_wait_until_signalled.run()
    cmd_serve.run()
others use self.outf

Tags:

Related branches

lp://staging/~barcc/bzr/268573-outf

lp://staging/~jelmer/brz/268573-outf

Merged into lp://staging/brz at revision 6835

Martin Packman: Approve on 2017-12-10

Revision history for this message

James Westby (james-w) wrote on 2008-09-10:

Hi,

I am confirming this, as I believe everything should use
self.outf now.

Thanks,

James

Changed in bzr:
importance:	Undecided → Low
status:	New → Confirmed

B. Clausius (barcc) on 2008-09-11

Changed in bzr:
assignee:	nobody → barcc
status:	Confirmed → In Progress

Revision history for this message

B. Clausius (barcc) wrote on 2008-09-11:

I just noticed, that there are other methods that use print for output. Likely they also should use self.outf.
i.e.: cmd_rocks.run :-)
There at least one method (cmd_serve.run) uses sys.stdout and print.

Revision history for this message

Vincent Ladeuil (vila) wrote on 2008-09-12:

Well cmd_rocks try to do the strict minimum so one can argue that it doesn't need to use self.outf :)

B. Clausius (barcc) on 2008-12-28

Changed in bzr:
assignee:	barcc → nobody
status:	In Progress → Confirmed

Jelmer Vernooij (jelmer) on 2017-11-09

tags:

added: check-for-breezy

Jelmer Vernooij (jelmer) on 2017-12-04

Changed in brz:
status:	New → Triaged
status:	Triaged → In Progress
importance:	Undecided → Low
assignee:	nobody → Jelmer Vernooij (jelmer)
tags:	added: ui removed: check-for-breezy

Jelmer Vernooij (jelmer) on 2017-12-11

Changed in brz:
status:	In Progress → Fix Released
milestone:	none → 3.0.0

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.