bzr commit -x doesn't change the --show-diff output (iter_changes does not support excludes)

On 19/03/10 08:29, Martin Pool wrote:
> ** Tags added: commit

I think the root cause for this is a dupe: show-diff output uses the
diff feature of bzr, and that depends on iter changes and there is abug
open that iter changes doeswn't support excludes.

Cheers,
Rob

Well, I can't find that bug, so we may as well make this be it.

I don't agree that this is the cause. Adding excludes support to iter_changes would be one approach, but it would be equally effective to filter the iter_changes output, and this would avoid the need to implement such filtering on every iter_changes implementation.

On Sat, 2010-04-10 at 15:49 +0000, Aaron Bentley wrote:
> I don't agree that this is the cause. Adding excludes support to
> iter_changes would be one approach, but it would be equally effective to
> filter the iter_changes output, and this would avoid the need to
> implement such filtering on every iter_changes implementation.

Assuming that filtering can be done correctly by layering (I'm not sure
that that is the case), we could build that helper into the core.

-Rob