failed commits do not save log message anymore

Bug #267017 reported by Robert Collins
40
This bug affects 9 people
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Low
Unassigned

Bug Description

I'm pretty sure we used to save the log message if a commit failed at
any point.

However, I think the new callback code undid that, and while its better
in lots of ways its frustrating for users when a commit does fail.
(Reported from a bzr 1.6 user getting a TooManyConcurrentConnections
error on a bound branch commit)

 affects bzr
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Revision history for this message
John A Meinel (jameinel) wrote :

I think there is some question as to *where* they should be saved.

When we wrote the callback code, we changed it so the log message is generated as late as reasonably possible, which was considered better than asking earlier and leaving more messages around.

I can understand the frustration when it still fails, though, so we should consider bringing something back.

Perhaps it would fit in with the ideas for 'uncommit' and 'gcommit' saving log messages, so that you can easily commit with the same message.

Changed in bzr:
importance: Undecided → Low
status: New → Triaged
Martin Pool (mbp)
Changed in bzr:
status: Triaged → Confirmed
Jelmer Vernooij (jelmer)
tags: added: commit
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.