Locks acquired via the smart protocol have poor lock info.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Medium
|
Unassigned | ||
Breezy |
Triaged
|
Low
|
Unassigned | ||
Launchpad itself |
Triaged
|
Low
|
Unassigned |
Bug Description
When you lock a branch or repository via the smart protocol (e.g. over bzr://), the lock info in the lock has no information about the client that took the lock, because at the moment the lock info is generated entirely by the server with no input from the client.
This causes unhelpful messages when there's lock contention, or a stale lock, i.e. "Unable to take lock XXX held by bzr-service@server" rather than "... held by bob@his-laptop".
This particularly affects the bzr+ssh:
The Branch.lock_write and Repository.
Changed in launchpad-bazaar: | |
milestone: | 1.1.12 → 1.2.1 |
Changed in launchpad-bazaar: | |
importance: | Medium → Low |
milestone: | 1.2.1 → none |
Changed in bzr: | |
importance: | Undecided → Medium |
status: | New → Confirmed |
tags: | added: check-for-breezy |
tags: | removed: check-for-breezy |
Changed in brz: | |
status: | New → Triaged |
importance: | Undecided → Low |
A possible alternative solution for bzr+ssh: //bazaar. launchpad. net/ specifically would be to teach that server to use the username (or user id) from the SSH authentication rather than "supermirror@ vostok" when generating a lock info file. This might be a good idea anyway, for dealing gracefully with older clients that don't have this fix.