missing integration tests of lightweight checkout and remote repository
Bug #1046697 reported by
John A Meinel
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
In Progress
|
Medium
|
John A Meinel |
Bug Description
bug #1046284 was caused because WT.get_file_text was using the iter_files_bytes method in a manner that ended up incompatible with RemoteRepository.
We didn't discover this until 2.5 was rolled out into production because we are missing integration tests about it. It should be possible to just add a permutation which is a WT checkout + RemoteRepository and run all the WT tests against it.
I had a start at doing this, but there is a small amount of fallout. This is mainly because the tests assume that the repo and the WT reside in the same location, which is broken by a lightweight checkout.
Related branches
lp://staging/~jameinel/bzr/2.5-remote-wt-tests-1046697
- Richard Wilbur: Approve
-
Diff: 596 lines (+189/-76)14 files modifiedbzrlib/remote.py (+15/-6)
bzrlib/smart/repository.py (+12/-9)
bzrlib/tests/per_tree/__init__.py (+18/-4)
bzrlib/tests/per_workingtree/__init__.py (+39/-6)
bzrlib/tests/per_workingtree/test_commit.py (+3/-2)
bzrlib/tests/per_workingtree/test_executable.py (+1/-2)
bzrlib/tests/per_workingtree/test_parents.py (+5/-3)
bzrlib/tests/per_workingtree/test_remove.py (+1/-1)
bzrlib/tests/per_workingtree/test_smart_add.py (+3/-0)
bzrlib/tests/per_workingtree/test_views.py (+2/-2)
bzrlib/tests/per_workingtree/test_workingtree.py (+24/-29)
bzrlib/tests/test_selftest.py (+39/-9)
bzrlib/workingtree_4.py (+19/-3)
doc/en/release-notes/bzr-2.5.txt (+8/-0)
Changed in bzr: | |
status: | Triaged → In Progress |
To post a comment you must log in.