Bazaar Windows Installers

bzr.exe will only use the system msvcrt90.dll from system32, never the bundled one

Bug #632465 reported by Alexander Belchenko on 2010-09-07

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	Bazaar	Fix Released	High	Martin Packman	Bazaar 2.3b3
	Bazaar Windows Installers	Fix Released	Critical	Martin Packman

Bug Description

If user has no msvcr90.dll installed on his system (which is true for vanilla Windows XP systems) bzr.exe won't work, furthermore our bzr_postinstall.exe application can't work either. Which is really bad.

WORKAROUND: user should install Microsoft Visual C++ 2008 Redistributable Package BEFORE installing bzr 2.2.x (or later).
User can download this package from
http://www.microsoft.com/downloads/details.aspx?FamilyID=9b2da534-3e03-4391-8a4d-074b9f2bc1bf

See original description

Related branches

lp://staging/~gz/bzr-windows-installers/include_manifest_in_installer_632465

Merged into lp://staging/bzr-windows-installers at revision 139

Gary van der Merwe: Approve on 2010-10-17

Alexander Belchenko: Approve on 2010-10-16

Revision history for this message

Martin Packman (gz) wrote on 2010-09-08:

Can confirm that it uses the SxS dll not the one that comes with the installer. Don't know if this means it wouldn't run at all on a machine without that.

Changed in bzr-windows-installers:
status:	New → Confirmed

Revision history for this message

Alexander Belchenko (bialix) wrote on 2010-09-30:

As Eli Zaretsky pointed in the ML even our post_install script fails without this dll.

Changed in bzr-windows-installers:
importance:	Undecided → High

Alexander Belchenko (bialix) on 2010-09-30

summary:	- [manifest?] bzr.exe using system msvcrt90.dll from sxs, not the bundled - one + bzr.exe using system msvcrt90.dll from sxs, not the bundled one
summary:	- bzr.exe using system msvcrt90.dll from sxs, not the bundled one + bzr.exe tried to use the system msvcrt90.dll from system32, not the + bundled one
description:	updated
Changed in bzr-windows-installers:
importance:	High → Critical
description:	updated

Revision history for this message

Martin Packman (gz) wrote on 2010-10-01: Re: bzr.exe tried to use the system msvcrt90.dll from system32, not the bundled one

I've got a fix here. Copying the manifest is all that's actually needed, but we may as well put it and the C runtime in a subdir as suggested in the py2exe tutorial:
<http://www.py2exe.org/index.cgi/Tutorial#Step521>

Changed in bzr-windows-installers:
assignee:	nobody → Martin [gz] (gz)
status:	Confirmed → In Progress

Revision history for this message

Martin Packman (gz) wrote on 2010-10-04:

What libraries bundled with 2.2.1 link against and contain in manifests Edit (9.8 KiB, text/plain)

See attachment for which libraries are affected. My first pass fix resolved the issue for everything that links against MSVCRT90.dll and doesn't reference it in a manifest. Those with manifests that do, and QtCore4.dll which also links MSVCP90.dll still fail to load.

Martin Packman (gz) on 2010-10-04

summary:

- bzr.exe tried to use the system msvcrt90.dll from system32, not the
+ bzr.exe will only use the system msvcrt90.dll from system32, never the
bundled one

Revision history for this message

Gary van der Merwe (garyvdm) wrote on 2010-10-18:

bzr-2.2.1-2-setup.exe has been uploaded, which fixes this.