Upload plugin throws NotImplementedError for filetype 'symlink'

Bug #659670 reported by Kyle Bassett
This bug report is a duplicate of:  Bug #214825: Doesn't support uploading symlinks. Edit Remove
This bug affects 1 person
Affects Status Importance Assigned to Milestone
bzr Upload plugin

Bug Description

The Upload plugin needs support for 'symlink' file types. A way to detect remote filesystem type/symlink support would be preferable, otherwise it should warn the user of the symlinks that will not be uploaded.

Temporarily, I modified __init__.py as follows:

[in def upload_full_tree @line 447]:
elif ie.kind == 'directory': #existing
elif ie.kind == 'symlink': #new
    self.upload_file_robustly(relpath, ie.file_id)

This modification does not address other functions where the 'symlink' file type may appear, such as UploadTree. The modification also assumes that the receiving filesystem can handle symlinks correctly.

Related branches

Martin Pool (mbp)
affects: bzr → bzr-upload
Changed in bzr-upload:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Kyle Bassett (kylebassett) wrote :

This bug is related to #214825.

Revision history for this message
Vincent Ladeuil (vila) wrote :

This is partly fixed by bug #477224 and worked on in bug #214825, so I'm marking this one as a duplicate of the later.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.