bzr Upload plugin

Error message unclear when using bzr+ssh protocol (InvalidURL error )

Bug #406206 reported by Martin Pool
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Breezy
Fix Released
Medium
Unassigned
Breezy 3.0.0 "Pelican"
bzr Upload plugin
Confirmed
Low
Unassigned

Bug Description

chrispitzer: i'm having problems with bzr upload. when I try to upload a repo, i get bzr: ERROR: Invalid url supplied to transport: "README.txt"
chrispitzer: what's up - is this a permissions issue or something...?
lifeless: what url are you giving bzr upload to push to?
chrispitzer: bzr upload bzr+ssh://my.server.com/srv/foo
chrispitzer: it should be using the user 'chris' just like when i ssh in.
poolie: this sounds familiar
poolie: is there a backtrace in .bzr.log?
chrispitzer: when i ssh in I can make files in that folder easily
poolie: chrispitzer: so it looks like a bug or an incompatibility between bzr and the upload plugin
poolie: i assume you do actually want the tree contents uploaded?
poolie: i mean, that you want a full checkout on the server
chrispitzer: yea
chrispitzer: it works great for a bunch of sites I use it on... bzr upload that is.
chrispitzer: it just doesn't want to work this time.
chrispitzer: *shrug* time to get on with my life I guess. :P
16:55
chrispitzer: thanks anyway - later
chrispitzer left the room.

Tue 2009-07-28 23:38:33 -0700
0.047 bzr arguments: [u'upload', u'bzr+ssh://zim.lofiart.com/srv/eatshop']
0.053 looking for plugins in /home/chris/.bazaar/plugins
0.053 looking for plugins in /usr/lib/python2.6/dist-packages/bzrlib/plugins
0.102 encoding stdout as sys.stdout encoding 'UTF-8'
0.160 opening working tree '/home/chris/src/eat.shop/pubtool'
0.266 ssh implementation is OpenSSH
1.336 Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 716, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 911, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 547, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/upload/__init__.py", line 123, in run
    self.upload_tree()
  File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/upload/__init__.py", line 248, in upload_tree
    self.upload_full_tree()
  File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/upload/__init__.py", line 226, in upload_full_tree
    self.upload_file(dp, ie.file_id)
  File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/upload/__init__.py", line 147, in upload_file
    self.to_transport.put_bytes(relpath, self.tree.get_file_text(id))
  File "/usr/lib/python2.6/dist-packages/bzrlib/transport/remote.py", line 264, in put_bytes
    (self._remote_path(relpath), self._serialise_optional_mode(mode)),
  File "/usr/lib/python2.6/dist-packages/bzrlib/transport/remote.py", line 175, in _remote_path
    return self._combine_paths(self._path, relpath)
  File "/usr/lib/python2.6/dist-packages/bzrlib/transport/__init__.py", line 461, in _combine_paths
    raise errors.InvalidURL(relpath)
InvalidURL: Invalid url supplied to transport: "README.txt"

Revision history for this message
Vincent Ladeuil (vila) wrote :

I'm not sure what upload should do there...(apart from not blowing up like this, that is).
If bzr is available on the remote site, there is no point in using upload,
https://edge.launchpad.net/bzr-push-and-update is far more appropriate (and works today),
and 'bzr push' itself should populate the working tree (but I'm not sure the smart server does that today).

upload is mostly targeted at remote sites where bzr can't be installed and will never be as smart
as the two solutions above.

Changed in bzr-upload:
status: New → Confirmed
importance: Undecided → Low
Vincent Ladeuil (vila)
summary: - InvalidURL error
+ InvalidURL error when using bzr+ssh protocol
Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 406206] Re: InvalidURL error

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> I'm not sure what upload should do there...(apart from not blowing up like this, that is).
> If bzr is available on the remote site, there is no point in using upload,
> https://edge.launchpad.net/bzr-push-and-update is far more appropriate (and works today),
> and 'bzr push' itself should populate the working tree (but I'm not sure the smart server does that today).
>
> upload is mostly targeted at remote sites where bzr can't be installed and will never be as smart
> as the two solutions above.

Well, there are people who would have bzr on the remote server, but want
to not upload the history to their http site. (So they don't have to
worry as much about disabling download of the history.)

That's about the only situation I can think of.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqelrYACgkQJdeBCYSNAAOIKwCgvD0UXDc64+vVRjU55xyhNhgI
oCYAn3ko7/80j8Rmso22d9mlSmnV6WEh
=N11G
-----END PGP SIGNATURE-----

Revision history for this message
Vincent Ladeuil (vila) wrote :

>>>>> "jam" == John A Meinel writes:

    jam> Vincent Ladeuil wrote:
    >> I'm not sure what upload should do there...(apart from not blowing up like this, that is).
    >> If bzr is available on the remote site, there is no point in using upload,
    >> https://edge.launchpad.net/bzr-push-and-update is far more appropriate (and works today),
    >> and 'bzr push' itself should populate the working tree (but I'm not sure the smart server does that today).
    >>
    >> upload is mostly targeted at remote sites where bzr can't be installed and will never be as smart
    >> as the two solutions above.

    jam> Well, there are people who would have bzr on the remote server, but want
    jam> to not upload the history to their http site. (So they don't have to
    jam> worry as much about disabling download of the history.)

    jam> That's about the only situation I can think of.

Right. So they want to use bzr but without the bzr data (.bzr directory).

Given that bzr-upload do all the heavy work on the *client* and
the smart server is about taking advantage of the remote
knowledge of the branch, either you use bzr-upload and 'sftp://'
(i.e. not 'bzr+ssh://') OR you use bzr with its data (but if you
don't want the '.bzr' in your published directory, you're back to
square one).

So, I say this bug is about pointing people in the right
direction if they try to use bzr+xxx protocol.

Vincent Ladeuil (vila)
summary: - InvalidURL error when using bzr+ssh protocol
+ Error message unclear when using bzr+ssh protocol (InvalidURL error )
Jelmer Vernooij (jelmer)
Changed in brz:
milestone: none → 3.0.0
importance: Undecided → Medium
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.