Bazaar hookless email

Use a more descriptive MIME type

Bug #533009 reported by Stefan Monnier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar hookless email
Confirmed
Undecided
Unassigned

Bug Description

Please use a MIME type like "text/x-diff" or "text/x-patch" for the attachment instead of just "text/plain", so that MUAs have a better chance of handling them as nicely as they can.
I originally reported it to Savannah (http://savannah.gnu.org/support/?107275), which redirected me here.

Revision history for this message
Stefan Monnier (monnier) wrote :

Anybody listening? It should be fairly easy to change, right? Or is there a problem with the idea itself?

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

The change seems fine, it just needs somebody with the time to actually implement this.

Changed in bzr-hookless-email:
status: New → Confirmed
Revision history for this message
Glenn Morris (rgm+lp) wrote :

Well, bzr_hookless uses bzrlib's msg.add_inline_attachment function, and that has an optional mime_subtype argument, so the
necessary change would seem to be a one liner:

--- bzr_hookless_email.py 2012-03-22 15:15:15 +0000
+++ bzr_hookless_email.py 2012-09-05 07:37:15 +0000
@@ -287,7 +287,7 @@
                     diff_val += (" %d bytes (byte limit is %d)\n" %
                                  (numbytes, options.byte_limit))

- msg.add_inline_attachment(diff_val, diff_name)
+ msg.add_inline_attachment(diff_val, diff_name, 'x-diff')

         return msg

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.