viz refresh button doesn't refresh

Bug #489479 reported by Russel Winder
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Bazaar GTK+ Frontends
Triaged
Low
Unassigned

Bug Description

If you start a "bzr viz" then make some commits to the branch then press refresh, the new commits are not displayed. Refresh only refreshes the current display, it does not check to see if the branch as been changed first.

Revision history for this message
Russel Winder (russel) wrote :

I should have said: I am using a mirror branch of bzr.dev and of lp:bzr-gtk, both kept up to date. My bzr-gtk branch reports revision 667 as the latest.

Revision history for this message
Jasper Groenewegen (colbrac) wrote :

Fixing this might be a bit complicated. All the info used to populate the viz window comes from a branch object passed to the BranchWindow object. This branch object is constructed in ./commands.py and the magic that happens around lines 182-190 is a bit hard to grasp for me. Seems like you can construct a branch object build up from different locations, pass in some sort of list or revision object.
The bzr Branch object API does not seem to give a method to determine the branch location, the branch object has an update method but that tries to get new revisions from a parent branch, I did not find a method that would refresh the contents of the branch so it seems the branch object must be constructed again (this is what happens in Olive when you press refresh btw).

So, I think fixing this involves moving the magic from commands.py into the BranchView object so that it can be invoked on a refresh in the _refresh_clicked method on the BrandView object.

Any comments from Scott Remnant or another expert? :)

Changed in bzr-gtk:
status: New → Confirmed
Jelmer Vernooij (jelmer)
Changed in bzr-gtk:
status: Confirmed → Triaged
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.