bzr email commit hook

Diff highlighting in mail body

Bug #399398 reported by Display Name on 2009-07-14

Affects		Status	Importance	Assigned to	Milestone
	Launchpad itself	Invalid	Undecided	Unassigned
	bzr email commit hook	Triaged	Wishlist	Unassigned

Bug Description

It would be nice if bzr-email and launchpad itself included highlighted diffs in mail body, as in the attached screenshot. For bzr-email it would need to implement HTML emails (bug 399392).

See original description

Tags:

Display Name (user340562791542-deactivatedaccount) on 2009-07-14

summary:

- Diff highlighting
+ Diff highlighting in mail body

Revision history for this message

Diogo Matsubara (matsubara) wrote on 2009-07-15:

Do you mean emails sent through the code review system should be HTML emails, so they could be highlighted?

affects:	launchpad → launchpad-code
Changed in launchpad-code:
status:	New → Incomplete

Revision history for this message

Tim Penhey (thumper) wrote on 2009-07-15:

The emails from Launchpad will shortly have the diffs attached rather than inline. Personally my email client already syntax hilights diff attachments.

Changed in launchpad-code:
status:	Incomplete → Invalid

Revision history for this message

Vincent Ladeuil (vila) wrote on 2009-07-15: Re: [Bug 399398] Re: Diff highlighting in mail body

>>>>> "Tim" == Tim Penhey <email address hidden> writes:

Tim> The emails from Launchpad will shortly have the diffs
Tim> attached rather than inline.

Good.

Tim> Personally my email client already syntax hilights diff
Tim> attachments.

Same here.

Please, please, even if you make HTML mails in the future, make
it an opt-in behavior, HTML is *not* supported by all mail
clients and is a pain for scripting.

Display Name (user340562791542-deactivatedaccount) on 2009-10-04

description:

updated

Jelmer Vernooij (jelmer) on 2012-03-22