Test Suite ERROR: bzrlib.plugins.builddeb.tests.test_upstream.TarfileSourceTests.test_fetch_tarball_repackest_fetch_tarball_repack

Bug #712180 reported by Stefano Rivera
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
bzr-builddeb
Fix Released
High
Vincent Ladeuil

Bug Description

Environment: Trunk r507 on natty amd64, with distro-packaged bzr.

ERROR: bzrlib.plugins.builddeb.tests.test_upstream.TarfileSourceTests.test_fetch_tarball_repack
----------------------------------------------------------------------
_StringException: Text attachment: log
------------
105.564 opening working tree '/tmp/testbzr-cPItrB.tmp'
------------
Text attachment: traceback
------------
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/testtools/runtest.py", line 169, in _run_user
    return fn(*args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/testtools/testcase.py", line 499, in _run_test_method
    return self._get_test_method()()
  File "/home/stefanor/.bazaar/plugins/builddeb/tests/test_upstream.py", line 361, in test_fetch_tarball_repack
    source.fetch_tarball("foo", "2.0", "bar"))
  File "/home/stefanor/.bazaar/plugins/builddeb/upstream.py", line 526, in fetch_tarball
    repack_tarball(self.path, dest_name, target_dir=target_dir)
  File "/home/stefanor/.bazaar/plugins/builddeb/repack_tarball.py", line 243, in repack_tarball
    force_gz=force_gz)
  File "/home/stefanor/.bazaar/plugins/builddeb/repack_tarball.py", line 190, in _repack_other
    repacker.repack(target_f)
  File "/home/stefanor/.bazaar/plugins/builddeb/repack_tarball.py", line 115, in repack
    zip = zipfile.ZipFile(self.source_f, "r")
  File "/usr/lib/python2.6/zipfile.py", line 696, in __init__
    self._GetContents()
  File "/usr/lib/python2.6/zipfile.py", line 716, in _GetContents
    self._RealGetContents()
  File "/usr/lib/python2.6/zipfile.py", line 728, in _RealGetContents
    raise BadZipfile, "File is not a zip file"
BadZipfile: File is not a zip file
------------

Related branches

Revision history for this message
Stefano Rivera (stefanor) wrote :

This is python2.6 specific, for some reason

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

The python2.6 copy doesn't generate/read empty files I suspect.

Changed in bzr-builddeb:
status: New → Triaged
importance: Undecided → High
Jelmer Vernooij (jelmer)
Changed in bzr-builddeb:
assignee: nobody → Jelmer Vernooij (jelmer)
status: Triaged → In Progress
Vincent Ladeuil (vila)
Changed in bzr-builddeb:
assignee: Jelmer Vernooij (jelmer) → Vincent Ladeuil (vila)
Revision history for this message
Vincent Ladeuil (vila) wrote :

AIUI, it does an additional check and requires a valid zip file.

Vincent Ladeuil (vila)
Changed in bzr-builddeb:
status: In Progress → Fix Released
status: Fix Released → Fix Committed
Max Bowsher (maxb)
Changed in bzr-builddeb:
milestone: none → 2.7
Jelmer Vernooij (jelmer)
Changed in bzr-builddeb:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.