don't allow the rating column to be wider than the maximum number of possible stars
Bug #985931 reported by
Danielle Foré
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| BeatBox |
Fix Released
|
Low
|
Scott Ringwelski | ||
| Noise |
Fix Released
|
Low
|
Victor Martinez | ||
Bug Description
Just what it says on the tin. The Rating column shouldn't be allowed to be wider than the number of stars it contains.
Related branches
lp://staging/~victored/noise/fixes
- Victor Martinez (community): Approve
-
Diff: 16277 lines (+3358/-10410)81 files modifiedCMakeLists.txt (+16/-18)
core/Player.vala (+1/-1)
plugins/LastFM/AlbumInfo.vala (+5/-5)
plugins/LastFM/ArtistInfo.vala (+8/-9)
plugins/LastFM/CMakeLists.txt (+5/-3)
plugins/LastFM/Core.vala (+7/-4)
plugins/LastFM/Icons.vala (+2/-2)
plugins/LastFM/LastFM.vala (+1/-1)
plugins/LastFM/SimilarMediaWidget.vala (+2/-2)
plugins/LastFM/SimilarViewWrapper.vala (+9/-8)
plugins/LastFM/TrackInfo.vala (+1/-2)
plugins/LastFM/schemas/CMakeLists.txt (+0/-1)
plugins/MPRIS/MPRIS.vala (+5/-5)
plugins/internet-radio/RadioListView.vala (+0/-538)
plugins/internet-radio/StationEditor.vala (+0/-234)
plugins/internet-radio/internet-radio.svg (+0/-531)
plugins/podcasts/CMakeLists.txt (+0/-30)
plugins/podcasts/icons/library-podcast.svg (+0/-725)
plugins/podcasts/icons/podcast-new.svg (+0/-148)
plugins/podcasts/podcasts.plugin (+0/-10)
plugins/podcasts/src/AddPodcastWindow.vala (+0/-209)
plugins/podcasts/src/PodcastEditor.vala (+0/-273)
plugins/podcasts/src/PodcastManager.vala (+0/-452)
plugins/podcasts/src/Podcasts.vala (+0/-17)
plugins/podcasts/src/View/PodcastListView.vala (+0/-841)
plugins/store/Artist.vala (+0/-196)
plugins/store/Basket.vala (+0/-36)
plugins/store/BasketItem.vala (+0/-37)
plugins/store/FormatTag.vala (+0/-35)
plugins/store/Label.vala (+0/-47)
plugins/store/Price.vala (+0/-39)
plugins/store/Release.vala (+0/-156)
plugins/store/SearchResult.vala (+0/-28)
plugins/store/Store.vala (+0/-556)
plugins/store/Track.vala (+0/-78)
plugins/store/Widgets/AlbumView.vala (+0/-366)
plugins/store/Widgets/ArtistView.vala (+0/-211)
plugins/store/Widgets/HomeView.vala (+0/-235)
plugins/store/Widgets/IconView.vala (+0/-131)
plugins/store/Widgets/ObjectList.vala (+0/-121)
plugins/store/Widgets/ReleaseRotator.vala (+0/-134)
plugins/store/Widgets/SearchList.vala (+0/-252)
plugins/store/Widgets/SearchResultsPage.vala (+0/-113)
plugins/store/Widgets/StoreView.vala (+0/-169)
plugins/store/Widgets/TagGroup.vala (+0/-115)
plugins/store/Widgets/TagLabel.vala (+0/-112)
plugins/store/Widgets/TrackList.vala (+0/-135)
plugins/store/XMLParser.vala (+0/-270)
po/CMakeLists.txt (+2/-2)
po/noise.pot (+209/-202)
src/CMakeLists.txt (+10/-7)
src/Dialogs/FileNotFoundDialog.vala (+2/-1)
src/Dialogs/MediaEditor.vala (+1/-1)
src/Dialogs/PlaylistNameWindow.vala (+15/-8)
src/Dialogs/SmartPlaylistEditor.vala (+5/-0)
src/Icons.vala (+79/-79)
src/LibraryManager.vala (+914/-916)
src/LibraryWindow.vala (+82/-114)
src/Objects/MediaArtCache.vala (+18/-7)
src/PlaybackManager.vala (+588/-599)
src/Utils/Search.vala (+134/-79)
src/Views/ListView/ListView.vala (+9/-6)
src/Views/ListView/Lists/CellDataFunctionHelper.vala (+181/-158)
src/Views/ListView/Lists/GenericList.vala (+200/-157)
src/Views/ListView/Lists/MusicListView.vala (+1/-1)
src/Views/ListView/Lists/TreeViewColumnSizer.vala (+259/-0)
src/Views/ListView/Lists/TreeViewSetup.vala (+2/-2)
src/Views/Wrappers/DeviceViewWrapper.vala (+7/-4)
src/Views/Wrappers/HistoryViewWrapper.vala (+6/-2)
src/Views/Wrappers/MusicViewWrapper.vala (+9/-2)
src/Views/Wrappers/NetworkDeviceViewWrapper.vala (+2/-0)
src/Views/Wrappers/PlaylistViewWrapper.vala (+35/-25)
src/Views/Wrappers/QueueViewWrapper.vala (+19/-20)
src/Views/Wrappers/ViewWrapper.vala (+97/-99)
src/Widgets/RatingWidget.vala (+4/-4)
src/Widgets/SideTreeView.vala (+15/-116)
src/Widgets/SidebarPaned.vala (+42/-12)
src/Widgets/SimpleOptionChooser.vala (+19/-22)
src/Widgets/StatusBar.vala (+210/-122)
src/Widgets/ViewSelector.vala (+120/-0)
vapi/CMakeLists.txt (+0/-2)
| Changed in noise: | |
| importance: | Undecided → Low |
| milestone: | none → 1.0 |
| status: | New → Confirmed |
| Changed in beat-box: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| tags: | added: beatbox-merge |
| tags: | removed: beatbox-merge |
Revision history for this message
| Danielle Foré (danrabbit) wrote | #1 |
| Changed in noise: | |
| milestone: | luna-beta1 → none |
| Changed in noise: | |
| assignee: | nobody → Victor Eduardo (victored) |
| status: | Confirmed → In Progress |
| milestone: | none → luna-beta1 |
| Changed in noise: | |
| status: | In Progress → Fix Committed |
| Changed in beat-box: | |
| status: | Triaged → Fix Committed |
| assignee: | nobody → Scott Ringwelski (sgringwe) |
| milestone: | none → 0.7 |
| Changed in beat-box: | |
| status: | Fix Committed → Fix Released |
| Changed in noise: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
while this would be nice to have, it's probably not really a beta blocker.