Odoo Addons (MOVED TO GITHUB)

Invoice line subtotal rounding issue

Bug #977300 reported by Paulius Sladkevičius @ hbee on 2012-04-09

This bug affects 4 people

	Status	Importance	Assigned to	Milestone
Odoo Addons (MOVED TO GITHUB)	Fix Released	Low	OpenERP R&D Addons Team 3
Therp Backports (Deprecated)	Status tracked in Addons-6.1
Addons-6.1	Fix Released	Undecided	Ronald Portier (Therp)	Therp Backports (Deprecated) fixed-after-61

Bug Description

I have faced rounding issue with quantity 2.5 and price 4.83.

[RESULT OBSERVED]
2.5 x 4.83 = 12.07

[RESULT EXPECTED]
2.5 x 4.83 = 12.08

I found that issue came from the account compute_all() method http://bazaar.launchpad.net/~openerp/openobject-addons/trunk/view/head:/account/account.py#L2072. For currency OpenERP use float_round() function to "fix" rounding issue, but here python default round() function used and of course it don't round correctly.

And from here comes, why in the other accounting parts float_round() is not used instead round()?

Related branches

lp://staging/~openerp-dev/openobject-addons/trunk-bug-977300-rmu

Merged into lp://staging/openobject-addons at revision 7111

Amit Parik (community): Approve on 2012-05-01

lp://staging/~therp-nl/therp-backports/addons-6.1_lp882036_account_rounding

Merged into lp://staging/therp-backports at revision 6714

Stefan Rijnhart (Opener) (community): Approve on 2013-04-10

lp://staging/~credativ/openobject-addons/6.1-lp977300-Invoice_line_subtotal_rounding_issue

Merged into lp://staging/~credativ/openobject-addons/6.1 at revision 7057

Craig Gowing (credativ): Approve on 2013-12-02

Revision history for this message

Paulius Sladkevičius @ hbee (komsas) wrote on 2012-04-09:

patch.diff Edit (751 bytes, text/plain)

Here is simple patch.

Revision history for this message

Ravish(OpenERP) (rmu-openerp) wrote on 2012-04-10:

Hello Paulius

I have checked your issue in both 6.1 stable and trunk .But for me ,it's working fine
Would you please provide more and sufficient steps to reproduce it.

Thanks!!

Changed in openobject-addons:
status:	New → Incomplete

Revision history for this message

Paulius Sladkevičius @ hbee (komsas) wrote on 2012-04-10:

photo 2012-04-10 17:35:13.png Edit (124.4 KiB, image/png)

Ravish,

check invoice screenshot and 3rd invoice line with description "test A" and you can see that subtotal is not correct. I have tested this on the v61 stable last revision.

Changed in openobject-addons:
status:	Incomplete → New

Revision history for this message

Ravish(OpenERP) (rmu-openerp) wrote on 2012-04-11:

Hello,

I have checked further ,But ended with same result.
For your more reference ,I have attached screen-shot.Please have a look.

I have tested with following Revision Number

Server: 4140
client: 2300
Addons: 6734

Thanks!!

Revision history for this message

Ravish(OpenERP) (rmu-openerp) wrote on 2012-04-11:

For more info... see this Screen-shot Edit (179.7 KiB, image/png)

Changed in openobject-addons:
status:	New → Incomplete

Revision history for this message

Paulius Sladkevičius @ hbee (komsas) wrote on 2012-04-11:

Ravish,

I have pulled last revisions now and rounding still incorrect, please give me your python version and try on yours: python -c "print round(2.5*4.83,2)", what value you get? Its a bit strange why we get different result with same source.

I'm using rev:
Server: 4141
client: 2300
Addons: 6735

Changed in openobject-addons:
status:	Incomplete → New

Revision history for this message

Paulius Sladkevičius @ hbee (komsas) wrote on 2012-04-11:

What I found out more about round and different python versions:
- Python 2.6.5, round(2.5*4.83,2) -> 12.08
- Python 2.7.2, round(2.5*4.83,2) -> 12.07

I found in the docs, that OpenERP support 2.6 and 2.7, so seems problem comes because Python versions act different.

Revision history for this message

Ravish(OpenERP) (rmu-openerp) wrote on 2012-04-12:

Hello,

As per different python versions ,I am conforming this issue.

Thanks!!

Changed in openobject-addons:
status:	New → Incomplete
status:	Incomplete → Confirmed
importance:	Undecided → Low
assignee:	nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)