Software Center Agent

Remove series data from available-apps-for-purchase api call

Bug #972565 reported by Anthony Lenton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Software Center Agent
Fix Released
Low
Danny Tamez
Software Center Agent 12.07

Bug Description

The 'series' key in the available-apps-for-purchase metadata is pointless, and it's getting larger with each distroseries we add. For some apps it's already above 10% of the total length of the published json.

It would be great if we could omit that data completely. We'd need to check that:
 - The client currently doesn't look or expect that data at all, and
 - We can either still provide it if architecture or distroseries is sent as "any", or apps.ubuntu.com can switch to use distroarchseries-specific calls instead, so we can remove the option to pass in "any" as a distroseries or arch tag.

Anthony Lenton (elachuni)
Changed in software-center-agent:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Michael Nelson (michael.nelson) wrote :

I think we forgot about the ability to filter for apps by *any* series or arch - the results of which need series - as per bug 973821.

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Indeed, we'd caught this in an XXX in the code (from reviewsapp.utilities)

"""
XXX michaeln 2011-03-14 bug=734747 Optional parms for available_apps.
It would be great if we could just pull /apps/en/ubuntu/ and use
each items 'series' dict to populate this, rather than pulling each
distroserie/arch separately. If we can assume that an app sold via
softwarecenter will always be available for maverick i386, then we
could do just the one call too.
"""

See what you think.

Revision history for this message
Anthony Lenton (elachuni) wrote :

We should be able to store the published_json data with series in the DB, but remove the series field when it's published, if the requested series is != 'any'.

This would involve parsing the json for every request for published apps, but I think the performance hit wouldn't be all that bad.

Danny Tamez (zematynnad)
Changed in software-center-agent:
assignee: nobody → Danny Tamez (zematynnad)
status: Confirmed → In Progress
Revision history for this message
Michael Nelson (michael.nelson) wrote :

QA notes: verified that the series is now removed from:

1) http://sca.razorgirl.info/api/2.0/applications/en/ubuntu/precise/i386/ and (unexpectedly)
2) http://sca.razorgirl.info/api/2.0/applications/en/ubuntu/precise/any/

but is still present for:
3) http://sca.razorgirl.info/api/2.0/applications/en/ubuntu/any/any/ and
4) http://sca.razorgirl.info/api/2.0/applications/en/ubuntu/any/i386/

I naively expected (2) above to include the series dict, but that isn't specified above and may not be necessary.

Danny Tamez (zematynnad)
Changed in software-center-agent:
status: In Progress → Fix Committed
Dave Morley (davmor2)
Changed in software-center-agent:
status: Fix Committed → Fix Released
Dave Morley (davmor2)
Changed in software-center-agent:
milestone: none → 12.07
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.