Support GVFS (http://, ftp://, smb://, etc) via GIO API

Bug #960471 reported by Sergey "Shnatsel" Davidoff
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Scratch
Fix Released
Wishlist
Mario Guerriero

Bug Description

Scratch should use GIO for input/output. This way it will be able to access http://, ftp://, smb://, and other weird URLs transparently, like Gedit does.

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

This may be required for proper integration with Midori, so targeting it to Luna milestone.

Changed in scratch:
milestone: none → luna-beta1
importance: Undecided → Wishlist
Revision history for this message
Danielle Foré (danrabbit) wrote :

We're definitely past feature freeze. This will have to wait until Luna + 1. Un-targeting.

Changed in scratch:
milestone: luna-beta1 → none
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

This way Midori's text editor integration might be screwed.

Revision history for this message
Danielle Foré (danrabbit) wrote :

So don't set a text editor in midori. We're past feature freeze. It'll have to wait. We need to stabilize in order to release.

Revision history for this message
Cris Dywan (kalikiana) wrote :

Just to clarify, Midori can still support it through its fallback code path which stores remote files in the temporary folder.

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Christian, thanks for clarification! I've updated our defaults accordingly, should work now.

Revision history for this message
Mario Guerriero (mefrio-g) wrote :

Even if it is not needed for Luna I have to confirm it.

Changed in scratch:
status: New → Confirmed
Changed in scratch:
milestone: none → 1.2
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Turns out g_mapped_file_new() which Scratch uses now always resets file permissions to defaults, so editing a private file in Scratch makes it globally readable. Since GIO is the most desired alternative (and the only other known option is raw POSIX API), I'm setting priority to critical and targeting it to luna-beta1.

Changed in scratch:
importance: Wishlist → Critical
milestone: 1.2 → luna-beta1
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote : Re: Migrate to GIO

ouch; it's not g_mapped_file_new() - it's g_file_set_contents() which is used in Scratch and resets permissions

summary: - Support GIO (http://, ftp://, smb://, etc)
+ Migrate to GIO
Changed in scratch:
milestone: luna-beta1 → 1.2
Changed in scratch:
importance: Critical → Medium
summary: - Migrate to GIO
+ Support GVFS (http://, ftp://, smb://, etc) via GIO API
Changed in scratch:
importance: Medium → Wishlist
Revision history for this message
Mario Guerriero (mefrio-g) wrote :

I fixed this bug some commits ago.

Changed in scratch:
assignee: nobody → Mario Guerriero (mefrio-g)
status: Confirmed → Fix Committed
Changed in scratch:
status: Fix Committed → Fix Released
Changed in scratch:
status: Fix Released → Fix Committed
Cody Garver (codygarver)
Changed in scratch:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.