TTPAC unused image cleanup

Bug #956023 reported by Michael Peters
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Won't Fix
Low
Unassigned
2.3
Fix Released
Low
Unassigned

Bug Description

There are a significant number of images remaining in TTPAC that are no longer used, leftover from KCLS, etc.

This branch does a little cleanup on the image directory and nets us about a 200KB savings overall.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=ab04528c40910e411c525aeec904fd3d46148911

Tags: pullrequest
tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.2.0beta1
Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
milestone: 2.2.0beta1 → 2.2.0rc1
Revision history for this message
Bill Erickson (berick) wrote :

Michael, did you also scan the CSS files for images in use? I quick grep shows a few of the removed images may be in use in /web/css/skin/default/opac/style.css as background images.

My quick list:

Open-ILS/web/css/skin/default/opac/style.css: background: url('/images/banner-bg.png') no-repeat;
Open-ILS/web/css/skin/default/opac/style.css: background: url('/images/button-bg.png') no-repeat;
Open-ILS/web/css/skin/default/opac/style.css: background:url('/images/dropdown-hover.gif') no-repeat right center;
Open-ILS/web/css/skin/default/opac/style.css: background:url('/images/dropdown.gif') no-repeat right center;
Open-ILS/web/css/skin/default/opac/style.css: background:url('/images/facet_box_bg_bottom.png') no-repeat;
Open-ILS/web/css/skin/default/opac/style.css: background: url('/images/hp-links-mid.jpg') repeat-x;
Open-ILS/web/css/skin/default/opac/style.css: background:url('/images/utils-corner-left.png') no-repeat left top;
Open-ILS/web/css/skin/default/opac/semiauto.css:.left-corner { float: left; width: 163px; height: 30px; background: url('/images/utils-corner-mid.png') repeat-x top; }

I didn't check whether we are actually using the CSS classes in question, though. Can you confirm either way?

Revision history for this message
Michael Peters (mrpeters) wrote :

Bill -- from what I'd seen, these images aren't actually in use. They were the blue backgrounds from the KCLS skin. A while back we went through and took out lots of the backgrounds that were images and replaced them with CSS gradients.

I never saw these in use in the OPAC after we "Evergreen'd" it.

Revision history for this message
Bill Erickson (berick) wrote :

I thought that might be the case. Thanks M. I'm going to test/signoff and then push a follow-up patch to remove the unused CSS.

Revision history for this message
Bill Erickson (berick) wrote :
Changed in evergreen:
milestone: 2.2.0rc1 → 2.2.0
Changed in evergreen:
milestone: 2.2.0 → 2.2.1
Changed in evergreen:
milestone: 2.2.1 → 2.2.2
Revision history for this message
Ben Shum (bshum) wrote :

Looks good to me. When testing against current master, because of the recent conversion to template files for style.css, I ended up dropping the changes berick made in the style.css file. Looks like the master copy didn't have any of those images being used anyways. Haven't tested 2.2 branch, but assume that some tweaking may be needed to catch up with potential drift.

Sign-off for master: user/bshum/tpac-unused-image-cleanup

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/tpac-unused-image-cleanup

Revision history for this message
Bill Erickson (berick) wrote :

Merged to master / rel_2_3. Thanks, guys!

Ben Shum (bshum)
Changed in evergreen:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.