When working with read-only files, Scratch pretends they're saved

Bug #955140 reported by Sergey "Shnatsel" Davidoff
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Scratch
Fix Released
High
Mario Guerriero

Bug Description

When I open a file in Scratch to which I don't have write permissions (e.g. anything in /usr/share/applications/, or any system configs) and auto-save is enabled, Scratch neither shows a warning that the file is not autosaved or can't be saved to, nor warns me on exit that my changes are not saved. This is dreadful because it makes me lose my work.
I haven't tested the non-autosave mode.

Changed in scratch:
importance: Undecided → High
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

And also seems to crash on exit when working with a mix of writeable and read-only files.

Revision history for this message
Mario Guerriero (mefrio-g) wrote :

When the autosave is active the text view shouldn't be editable and when it is disactive the save button should be unsensitive...I just implemented it but it seems that it was broken

Changed in scratch:
status: New → Confirmed
milestone: none → luna-beta1
assignee: nobody → Mario Guerriero (mefrio-g)
Revision history for this message
Mario Guerriero (mefrio-g) wrote :

I pushed a fix. If you don't get other strange behavior, please set the bug status as "Fix committed"

Changed in scratch:
status: Confirmed → In Progress
Revision history for this message
Mario Guerriero (mefrio-g) wrote :

I made more test. It seems to be fixed

Changed in scratch:
status: In Progress → Fix Committed
Changed in scratch:
milestone: luna-beta1 → 1.1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.