rootwrap needs to be extensible
Bug #954375 reported by
Andrew Bogott
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Wishlist
|
Thierry Carrez |
Bug Description
Many Nova features allow drop-in drivers, and many of these drivers depend on tools that are not in the default set of tools wrapped by rootwrap.
So, we need a way for either
a) A driver to specific an additional tool for rootwrap to support, or
b) A way to specify additional rootwrap-supported tools as a config option.
Changed in nova: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | folsom-2 → 2012.2 |
To post a comment you must log in.
I understand the need. It's a bit tricky to get the security model for this right, though.
The current model is to allow sudo to run "/usr/bin/ nova-rootwrap" , which loads nova.rootwrap. wrapper from a pristine sys.path, which then tries to load a number of predetermined FILTERS_MODULES files. Adding more dynamic loading capabilities (like loading all files present under nova.rootwrap. filters) weakens this model a bit, but is probably still safe. You would then just package a nova.rootwrap. filters. myownextension together with your extension.
Alternatively we could allow sudo to run "/usr/bin/ nova-rootwrap --config /etc/nova/ rootwrap. conf" which would point to a list of files to load... but it makes in-branch testing a bit more difficult, and is also more error-prone (you have to replicate the config file location in the root_wrapper config option).
I'll add this to my Folsom improvements list.