rootwrap needs to be extensible

Bug #954375 reported by Andrew Bogott
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Wishlist
Thierry Carrez

Bug Description

Many Nova features allow drop-in drivers, and many of these drivers depend on tools that are not in the default set of tools wrapped by rootwrap.

So, we need a way for either

a) A driver to specific an additional tool for rootwrap to support, or
b) A way to specify additional rootwrap-supported tools as a config option.

Tags: rootwrap
Revision history for this message
Thierry Carrez (ttx) wrote :

I understand the need. It's a bit tricky to get the security model for this right, though.

The current model is to allow sudo to run "/usr/bin/nova-rootwrap", which loads nova.rootwrap.wrapper from a pristine sys.path, which then tries to load a number of predetermined FILTERS_MODULES files. Adding more dynamic loading capabilities (like loading all files present under nova.rootwrap.filters) weakens this model a bit, but is probably still safe. You would then just package a nova.rootwrap.filters.myownextension together with your extension.

Alternatively we could allow sudo to run "/usr/bin/nova-rootwrap --config /etc/nova/rootwrap.conf" which would point to a list of files to load... but it makes in-branch testing a bit more difficult, and is also more error-prone (you have to replicate the config file location in the root_wrapper config option).

I'll add this to my Folsom improvements list.

Changed in nova:
importance: Undecided → Wishlist
status: New → Confirmed
tags: added: rootwrap
Revision history for this message
Thierry Carrez (ttx) wrote :
Changed in nova:
milestone: none → folsom-2
status: Confirmed → Fix Committed
assignee: nobody → Thierry Carrez (ttx)
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.