double-click-icon-box in a @bookmarks subtree opens the URL twice

On Mon, Mar 12, 2012 at 10:48 PM, SegundoBob <email address hidden> wrote:
> Public bug reported:
>
> I've seen double-open problems for a long time.  When I first saw them,
> I concluded that they only occurred when you double-click-icon-box on an
> @url node in an @bookmarks subtree--so I didn't report it as a bug,
> because it seemed to be two plugins interacting.
>
> Now the problem seems to be a purely  bookmarks plugin problem.
>
> Now whenever you double-click-icon-box on a node in an @bookmarks
> subtree with a URL in the target node body, the URL is opened twice.

Thanks for this report. I've seen something similar, but was never
quite sure what was happening.

As mentioned in the thread
Let's stop abusing double-clicks!?
http://groups.google.com/group/leo-editor/browse_thread/thread/9a37d02be30cff02
I am having serious doubts about overloading double-clicks willy nilly
throughout Leo. I think some discipline is long overdue.

Edward

Fixed at rev 5138. Indeed, the bookmarks.py plugin is no longer involved in any way with opening urls or bookmarks.

On 03/14/2012 07:48 AM, Edward K. Ream wrote:
> Fixed at rev 5138. Indeed, the bookmarks.py plugin is no longer
> involved in any way with opening urls or bookmarks.
>
> ** Changed in: leo-editor
> Status: Confirmed => Fix Released
>

Oops. Now command double-click-icon-box has zero effects in an
@bookmarks subtree and double-click-icon-box also fails to open the url
of an @url node.

Behavior is the same when the bookmarks.py plugin is enabled and disabled.

Test System:
Ubuntu 11.10 with Fluxbox window manager
Leo Log Window
Leo 4.9.1 devel, build 5138, 2012-03-14 08:57:29
Python 2.7.2, qt version 4.7.3
linux2
setting leoID from os.getenv('USER'): 'bob'
load dir: /home/bob/bzr/LeoLatest/leo/core
global config dir: /home/bob/bzr/LeoLatest/leo/config
home dir: /home/bob
reading settings in /home/bob/bzr/LeoLatest/leo/config/leoSettings.leo
reading settings in /home/bob/.leo/myLeoSettings.leo
reading settings in /home/bob/.leo/workbook.leo
reading: /home/bob/.leo/workbook.leo

--
Segundo Bob
<email address hidden>

On Wed, Mar 14, 2012 at 11:08 AM, SegundoBob <email address hidden> wrote:

> Oops.  Now command double-click-icon-box has zero effects in an
> @bookmarks subtree and double-click-icon-box also fails to open the url
> of an @url node.
>
> Behavior is the same when the bookmarks.py plugin is enabled and
> disabled.

That is as I expect. Ctrl-click is now the way to open either a
bookmark or url, regardless of whether the bookmarks plugin is
enabled.

Edward

On 03/14/2012 11:50 AM, Edward K. Ream wrote:
> Ctrl-click is now the way to open either a
> bookmark or url, regardless of whether the bookmarks plugin is
> enabled.

That's unfortunate. That forces me to use the mouse, where before I
just typed Alt+F3 (which I bound to double-click-icon-box).

I thought you hated using the mouse even more than I do?

Doesn't this have the effect of making @bookmarks useless?
Doesn't this have the effect of making @url useless?

--
Segundo Bob
<email address hidden>

> That's unfortunate.  That forces me to use the mouse, where before I
> just typed Alt+F3 (which I bound to double-click-icon-box).

it makes sense to have a keyboard equivalent to ctrl-click.
Might I suggest [ctrl-enter] as a default?

It's less of a finger stretch than Alt-F#, is semantically more
equivalent to "act on this object", and is close to ctrl-click (in
that they both use ctrl).

Choice of default binding aside. I'm happy to have any binding.

--
-matt

On Wed, Mar 14, 2012 at 4:11 PM, Matt Wilkie <email address hidden> wrote:
>> That's unfortunate.  That forces me to use the mouse, where before I
>> just typed Alt+F3 (which I bound to double-click-icon-box).
>
> it makes sense to have a keyboard equivalent to ctrl-click.

Right. That is why I am going to create several new commands. Coming
in an hour or so.

> Might I suggest [ctrl-enter] as a default?

Possible. Any other suggestions?

Edward

On Thu, Mar 15, 2012 at 8:49 AM, Edward K. Ream
> ...several new commands [are coming] in an hour or so.

Done at rev 5139. The new commands are:

- ctrl-click-icon: simulates ctrl-clicking the icon box.
- ctrl-click-at-cursor: simulates ctrl-clicking body text.
- open-url: opens the url given in the selected node.
- open-url-under-cursor: opens the url at the cursor location of the body text.

I recommend just using open-url, and binding a keystroke to it.

All these commands to support plugins that might want to override
event handling.

Edward