Scratch

"Save unsaved changes" dialog looks bad/wrong

Bug #951511 reported by Andrea Basso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Scratch
Fix Released
Medium
Mario Guerriero
Scratch 1.1 "Iliad"

Bug Description

As you can see here http://imagebin.org/202734 , buttons are on the left (and IMO the cancel should be on the left, but this is just personal), the first line isn't aligned to the second and there's not enough padding (IIRC the e-default is 12px).

Mario Guerriero (mefrio-g)
Changed in scratch:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → 1.1
Revision history for this message
Mario Guerriero (mefrio-g) wrote :

I just pushed a commit where I substituted the use of the SaveDialog with the SaveOnCloseDialog. It looks "better" and has the layout which was decided by the designers

Changed in scratch:
assignee: nobody → Mario Guerriero (mefrio-g)
status: Confirmed → Fix Committed
Revision history for this message
Andrea Basso (voluntatefaber) wrote :

Another thing: we should use "Close without saving" instead of "Discard", it's clearer.

Revision history for this message
Andrea Basso (voluntatefaber) wrote :

Ok, just one more thing (btw, last comment was made before I saw you answer): why does it use "from the last 4 seconds"?

Revision history for this message
Mario Guerriero (mefrio-g) wrote :

It was decided by the designers who wanted to follow the gedit's one,
http://people.gnome.org/~paolo/screenshots/close-dialog/close-single.png

Revision history for this message
Danielle Foré (danrabbit) wrote :

I'd be interested to see how it looks with "close without saving". If the string isn't too long, it is much clearer.

I'm +/- 0 to the "last n seconds" thing if we decided we didn't like it.

Revision history for this message
Andrea Basso (voluntatefaber) wrote :

Dan: I think he was talking about the "last n seconds" thing, after last changes Scratch uses "Close without saving".

Mario: ok, but then why is it hardcoded?

Danielle Foré (danrabbit)
Changed in scratch:
milestone: luna-beta1 → 1.1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.