OOPS occurs if log out is attempted while deleting a device
Bug #948440 reported by
Julien Funk
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical SSO provider |
Fix Released
|
Medium
|
Stuart Metcalfe |
Bug Description
Steps:
1) Add a device
2) Select the 'Delete' button for this device
3) On the page where it is confirming if you want to delete the device, click 'Log out'
4) See the OOPS below:
Oops!
Sorry, something just went wrong in Ubuntu Single Sign On.
We’ve recorded what happened, and we’ll fix it as soon as possible. Apologies for the inconvenience.
(OOPS ID: 2257carambolaub
(Sentry ID: )
Related branches
lp://staging/~stuartmetcalfe/canonical-identity-provider/more-2f-fixes
- Simon Davy (community): Approve
-
Diff: 349 lines (+104/-31)14 files modifiedidentityprovider/media/ubuntu/forms.css (+1/-1)
identityprovider/media/ubuntu/styles.css (+27/-1)
identityprovider/templates/account/applications.html (+3/-3)
identityprovider/templates/account/delete_email.html (+4/-4)
identityprovider/templates/account/emails.html (+3/-3)
identityprovider/templates/device/list.html (+5/-5)
identityprovider/templates/launchpad/registration/twofactor.html (+2/-2)
identityprovider/templates/ubuntu/registration/twofactor.html (+2/-2)
identityprovider/templates/widgets/ubuntu/logout-button.html (+10/-2)
identityprovider/tests/acceptance/applications/delete_app.py (+2/-2)
identityprovider/tests/acceptance/logout/logout_deep_pages.py (+36/-0)
identityprovider/tests/acceptance/shared/helpers.py (+2/-2)
identityprovider/views/account.py (+1/-1)
identityprovider/views/ui.py (+6/-3)
Changed in canonical-identity-provider: | |
milestone: | none → 2-factor-post-rollout |
assignee: | nobody → Stuart Metcalfe (stuartmetcalfe) |
milestone: | 2-factor-post-rollout → 2-factor-internal-rollout |
Changed in canonical-identity-provider: | |
status: | In Progress → Fix Committed |
Changed in canonical-identity-provider: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Here's the traceback from my local dev instance:
Environment:
Request Method: GET localhost: 8000/device- removal/ +logout
Request URL: http://
Django Version: 1.3 contrib. auth', contrib. contenttypes' , contrib. messages' , contrib. sessions' , contrib. sites', contrib. admin', openid_ auth', der', configglue' , contrib. django' , contrib. django. middleware. SentryResponseE rrorIdMiddlewar e', der.middleware. time.TimeMiddle ware', der.middleware. dbfailover. DBFailoverMiddl eware', middleware. common. CommonMiddlewar e', contrib. sessions. middleware. SessionMiddlewa re', contrib. messages. middleware. MessageMiddlewa re', middleware. csrf.CsrfViewMi ddleware' , contrib. auth.middleware .Authentication Middleware' , der.middleware. useraccount. UserAccountConv ersionMiddlewar e', middleware. locale. LocaleMiddlewar e', der.middleware. exception. LogExceptionMid dleware' , contrib. django. middleware. Sentry404CatchM iddleware' ]
Python Version: 2.7.2
Installed Applications:
['django.
'django.
'django.
'django.
'django.
'django.
'django_
'identityprovi
'django_
'oauth_backend',
'preflight',
'gargoyle',
'nexus',
'saml2idp',
'adminaudit',
'raven.
'devserver',
'django_jenkins']
Installed Middleware:
['raven.
'identityprovi
'identityprovi
'django.
'django.
'django.
'django.
'django.
'identityprovi
'django.
'identityprovi
'raven.
Traceback: stuartm/ Python/ 829836- confirm- pw-to-change/ .env/local/ lib/python2. 7/site- packages/ Django- 1.3-py2. 7.egg/django/ core/handlers/ base.py" in get_response stuartm/ Python/ 829836- confirm- pw-to-change/ .env/local/ lib/python2. 7/site- packages/ Django- 1.3-py2. 7.egg/django/ contrib/ auth/decorators .py" in _wrapped_view stuartm/ Python/ 829836- confirm- pw-to-change/ identityprovide r/decorators. py" in _wrapped_view stuartm/ Python/ 829836- confirm- pw-to-change/ .env/local/ lib/python2. 7/site- packages/ gargoyle- 0.7.2-py2. 7.egg/gargoyle/ decorators. py" in wrapped stuartm/ Python/ 829836- confirm- pw-to-change/ identityprovide r/views/ utils.py" in wrapper stuartm/ Python/ 829836- confirm- pw-to-change/ identityprovide r/views/ devices. py" in device_removal request. user) stuartm/ Python/ 829836- confirm- pw-to-change/ .env/local/ lib/python2. 7/site- packages/ Django- 1.3-py2. 7.egg/django/ shortcuts/ __init_ _.py" in get_object_or_404 stuartm/ Python/ 829836- confirm- pw-to-change/ .env/local/ lib/python2. 7/site- packages/ Django- 1.3-py2. 7.egg/django/ db/models/ query.py" in get stuartm/ Python/ 829836- confirm- pw-to-change/ .env/local/ lib/python2. 7/site- packages/ Django- 1.3-py2. 7.egg/django/ db/models/ query.py" in filter or_exclude( False, *args, **kwargs) stuartm/ Python/ 829836- confirm- pw-to-. ..
File "/home/
111. response = callback(request, *callback_args, **callback_kwargs)
File "/home/
23. return view_func(request, *args, **kwargs)
File "/home/
68. return view_func(request, *args, **kwargs)
File "/home/
26. return func(request, *args, **kwargs)
File "/home/
23. return fn(request, *args, **kwargs)
File "/home/
238. id=device_id, account=
File "/home/
113. return queryset.get(*args, **kwargs)
File "/home/
341. clone = self.filter(*args, **kwargs)
File "/home/
550. return self._filter_
File "/home/