Bazaar

texinfo is supported by sphinx under precise leading to test failures

Bug #940164 reported by Vincent Ladeuil
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
High
Unassigned
Bazaar 2.5.1

Bug Description

Just encounter test failures while running the final selftest for 2.5.0.

It seems that a native texinfo builder is now supported by sphinx.

We should evaluate whether the native plugin provide better support than our alpha quality one and act accordingly.

Related branches

lp://staging/~vila/bzr/940164-native-texinfo
Martin Packman (community): Approve
Gordon Tyler: Pending requested
Diff: 1649 lines (+123/-1286)
21 files modified
Makefile (+8/-0)
bzrlib/doc_generate/builders/__init__.py (+0/-20)
bzrlib/doc_generate/builders/texinfo.py (+0/-44)
bzrlib/doc_generate/conf.py (+1/-2)
bzrlib/doc_generate/writers/__init__.py (+0/-20)
bzrlib/doc_generate/writers/texinfo.py (+0/-534)
bzrlib/tests/__init__.py (+0/-1)
bzrlib/tests/doc_generate/__init__.py (+0/-113)
bzrlib/tests/doc_generate/builders/__init__.py (+0/-36)
bzrlib/tests/doc_generate/builders/test_texinfo.py (+0/-71)
bzrlib/tests/doc_generate/writers/__init__.py (+0/-36)
bzrlib/tests/doc_generate/writers/test_texinfo.py (+0/-359)
bzrlib/tests/features.py (+0/-1)
doc/developers/conf.py (+19/-9)
doc/en/Makefile (+3/-0)
doc/en/conf.py (+22/-12)
doc/en/release-notes/bzr-2.5.txt (+5/-1)
doc/en/whats-new/whats-new-in-2.5.txt (+7/-0)
doc/es/conf.py (+19/-9)
doc/ja/conf.py (+19/-9)
doc/ru/conf.py (+20/-9)
Revision history for this message
Vincent Ladeuil (vila) wrote :

Note that since we still haven't switch to sphinx for our official doc builds this shouldn't be a blocker either. The test failures should only be encountered where a recent sphinx is installed which means pqm and buildds should be safe.

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 940164] Re: texinfo is supported by sphinx under precise leading to test failures

On Fri, Feb 24, 2012 at 10:30:05AM -0000, Vincent Ladeuil wrote:
> Note that since we still haven't switch to sphinx for our official doc
> builds this shouldn't be a blocker either. The test failures should only
> be encountered where a recent sphinx is installed which means pqm and
> buildds should be safe.
 This is a blocker for uploading to Ubuntu. It's not really urgent as I
guess I could add a patch to disable sphinx altogether?

Cheers,

Jelmer

Revision history for this message
Vincent Ladeuil (vila) wrote :

We have sphinx as a dep for debian/ubuntu ? If yes, then disabling the tests is the way to unblock, pqm didn't complain and I only got this today for the first time so I was suspecting a *very* recent sphinx upload, I may be wrong.

Revision history for this message
Vincent Ladeuil (vila) wrote :

I left a debug statement in the texinfo builder while diagnosing the issue and it found its way in the 2.5.0 tarball :-(

I can think of only two cases where this will trigger:

1) trying to use the texinfo builder (no big deal, even where we use sphinx we don't use the texinfo builder in any production script I know about)

2) When running the full test suite where sphinx is installed which is already this bug.

I'm landing the removal of the offending statement in lp:bzr/2.5

Vincent Ladeuil (vila)
Changed in bzr:
status: Confirmed → In Progress
Vincent Ladeuil (vila)
Changed in bzr:
milestone: none → 2.5.1
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.