Not All Add Events forms show Date Format Change

Bug #938063 reported by Nat Katin-Borland
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
Low
Balazs Ree

Bug Description

Kenneth noticed several inconsistencies in the Date Format work (https://karl.soros.org/communities/karl-consortium/blog/fyi-ariadne-oxfam-just-got-the-latest-update/comments/010/). She the post for more screenshots.

---
Adding New Date-related events affects: - Add Calendar Entry (at Office level and in all communities) - Add Network Event (and similar modules, e.g., Network News, plus two other modules that we have on our home page)

When you click to add a new item, the date display box is in the U.S. date format. Although there is a visual calendar drop-down, I would still consider this an inconsistency for users. Three samples attached below.

Revision history for this message
Nat Katin-Borland (nborland) wrote :
  • ADD Edit (111.7 KiB, application/octet-stream)
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Move to future.

Changed in karl3:
importance: Undecided → Low
milestone: none → m94
Changed in karl3:
milestone: m94 → m97
Changed in karl3:
milestone: m97 → m100
Changed in karl3:
milestone: m100 → m104
Changed in karl3:
milestone: m104 → m108
Changed in karl3:
milestone: m108 → m111
Changed in karl3:
assignee: nobody → Carlos de la Guardia (cguardia)
Changed in karl3:
milestone: m111 → m110
Revision history for this message
Carlos de la Guardia (cguardia) wrote :

This one is a little tricky, since the widgets for date capture do not support globalize. Maybe ask Ree what he thinks?

Changed in karl3:
status: New → In Progress
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Carlos is right, this is a bigger ticket than I thought. We're not going to globalize the JS widgets any time soon.

Changed in karl3:
assignee: Carlos de la Guardia (cguardia) → Balazs Ree (ree)
milestone: m110 → m114
Balazs Ree (ree)
Changed in karl3:
status: In Progress → New
Balazs Ree (ree)
Changed in karl3:
status: New → Confirmed
JimPGlenn (jpglenn09)
Changed in karl3:
milestone: m114 → m117
Balazs Ree (ree)
Changed in karl3:
status: Confirmed → In Progress
JimPGlenn (jpglenn09)
Changed in karl3:
milestone: m117 → m118
Revision history for this message
Balazs Ree (ree) wrote :

The problem of the date formatting of the wiki index is now moved to its own ticket: #1051243. So this bug is removed from this pile.

Revision history for this message
Balazs Ree (ree) wrote :

Jim, this is ready for testing. It contains fixes for several problems which are related in a common way: the date formatting broken. This means that even if a user selects an EU date format in the profile, the US format is incorrectly displayed or handled. But otherwise all these cases had to receive their individual fix against this issue.

Please test all the issues on this page and on the KARL forum page linked from here, that is the one that contains the screenshots that show the problem locations. It is also important that all issues must be tested on both UX1 and UX2 independently, because as the implementations are separated, they may be just broken on one and work on the other.

I took out the wiki index problem from this pile. To reiterate what I fixed, I copy the changelog I wrote to here, as well:

- Fix date format problems where on various locations, the US date format
  was incorrectly displayed even if the user had selected an EU date format.
  (LP #938063)

  * start and end dates at show calendar event (ux1 + ux2) display only

  * blog comments (ux1 + ux2) display only

  * start_date, end_date fields of add/edit calendar events. This
     covers the support through both the form widget and the javascript
     (including the jquery-ui datepicker) stack

  * Publication Date field of the Add News Item

tags: added: branch-default
Changed in karl3:
status: In Progress → Fix Committed
Revision history for this message
JimPGlenn (jpglenn09) wrote :

ree, tested the items above and the following are the resuts:

* start and end dates at show calendar event (ux1+ ux2) display only - looks good passed test
* Blog comments (ux1+ux2) display only - looks good passed test
* publication date field of the Add News Item - Failed still shows US date

Changed in karl3:
status: Fix Committed → In Progress
Revision history for this message
Balazs Ree (ree) wrote :

Thanks!

I think I have added that I had forgotten. Please re-rest!

(Hint: add/edit form, ux1/ux2 gives 4 combinations to test...)

Changed in karl3:
status: In Progress → Fix Committed
Revision history for this message
JimPGlenn (jpglenn09) wrote :

retested and all looks good.

tags: added: tested
Revision history for this message
Nat Katin-Borland (nborland) wrote :

There's still some inconsistency in UX2. For example, the Recent Content grid doesn't seem to change properly in UX2.

Revision history for this message
Balazs Ree (ree) wrote :

Nat, I think it is a real possibility that there are other date format problems in ux2, that are yet unfixed. However if the bug you point out in your last comment was not on the original bug report, (which I think is the case but I am not sure) could you please enter it as a separate ticket? My objective is that if the locations that were reported in this ticket, are now tested to fix correctly, it is better to release the already correct fixes, and work on the additional problems in the next iteration (instead of, holding back all the five solved cases because there is more).

Revision history for this message
Nat Katin-Borland (nborland) wrote :

A new bug was created for my comment: https://bugs.launchpad.net/karl3/+bug/1057068

JimPGlenn (jpglenn09)
tags: added: r3.98
Revision history for this message
JimPGlenn (jpglenn09) wrote :

fixed

Changed in karl3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.