connecting to ADCS hubs shows public tag

Bug #933421 reported by Tanith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
LinuxDC++
New
Undecided
Unassigned

Bug Description

When connecting to ADCS hubs with linuxdcpp 1.1 (debian squeeze) as a registered user( or OP) the tag shows as being in a public hub and changes to private only after 10-15 seconds. In case of a single hub: 1/0/0 to 0/0/1.

This is causing problems in private hubs where no public hubs are tolerated and it makes login impossible when the check is performed during login.

This is regardless of the actual hubsoft, tested luadch, flexhub adchpp in the queue.

Logs from flexhub feed:

[13:13] <HUBSEC> [LOGIN] [A] [LAJ] [2] IP: xx.xx.xx.xx <nick unknown> HSUP OK.
[13:13] <HUBSEC> [FI] [0] Monitored nick is connecting... all traffic outputs to: Feed
[13:13] <HUBSEC> [LOGIN] [A] [LAJ] [4] IP: xx.xx.xx.xx <@ldcpp> BINF OK.
[13:13] <HUBSEC> [Monitoring <xx.xx.xx.xx>] [RCV] HPAS CID
[13:13] <HUBSEC> [X] [0] [Redirect] [GetAddress] Request: maxhubs / Path: USED:true LIST:Fix.your.maxhubs.settings! / Answer: Fix.your.maxhubs.settings!
[13:13] <HUBSEC> [FI] [1] [Redirect] maxhubsIP: xx.xx.xx.xx <@ldcpp> was redirected to: Fix.your.maxhubs.settings! because: Connected to too many public hubs, you have: 1, the hub maximum is: 0

Revision history for this message
Night (night.) wrote :

the new hub is counted too soon.

a possible fix for this would be when own INF is constructed and sent at AdcHub.cpp :

void AdcHub::info(bool /*alwaysSend*/)

line 499:
if (state == STATE_NORMAL)
 updateCounts(false);

Revision history for this message
Tanith (tanith) wrote :

Thanks Night,

 that solved the issue.

Revision history for this message
beefstick (splitwitch) wrote :

Solved the problem for me too.

One little mistake though. For the BZR the line is 690 in AdcHub.cpp

Normally looks like
updateCounts(false);
Should be changed to
if (state == STATE_NORMAL) updateCounts(false);

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.