OpenShot Video Editor

Adding project file by drag & drop does not update import_folder xml element

Bug #930647 reported by Robin Clarke
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenShot Video Editor
Fix Released
Low
Unassigned
OpenShot Video Editor 1.4.3

Bug Description

Every time I start up OpenShot it seems to do a non-trivial scan of my filesystem. I notice it because I have NTFS shares from another server mounted on my desktop, and the first time I start OpenShot it causes the disks on the server (in the same room) to spin-up. As this is a costly operation (scanning network servers with spun-down drives takes a few seconds!), I was wondering if it would be possible to not do such an invasive scan every time the application starts.

Revision history for this message
Robin Clarke (irreire) wrote :

OS: LXDE with kernel 3.0.0-15-generic
Installation: Synaptik package manager
OpenShot version: 1.4.0

Revision history for this message
Andy Finch (fincha) wrote :

OpenShot does not intentionally do a scan of your file system. Maybe you can run OpenShot from the terminal and see where the scan occurs in relation to the terminal output.

Revision history for this message
Robin Clarke (irreire) wrote :

Could it be that it accesses the path defined in the configuration element "import_folder"?
The first time I used it I used the "import Files..." dialogue, and imported files from an NFS mounted partition, which seems to have got that value set in the config.xml, and since then I have used the drag'n'drop functionality, but looking at the config.xml it seems the value wasn't changed.
I just created a new project and used the "import Files..." dialogue to set the location stored in the config to a local path, and now openshot starts fast again.

Assuming this is the root cause of the behaviour, suggested solutions:
1. Don't access the path defined in import_folder until "Import Files..." is clicked
2. Store the path from which a file was imported in the import_folder element even if it's added by drag'n'drop.

Revision history for this message
Andy Finch (fincha) wrote :

It only looks for the import folder when opening the Import Files dialog.

It looks for the config.xml config file at startup (it looks for this within your home folder, ~/.openshot to be precise), plus there are some checks that certain folders exist (such as /usr/share/openshot), but I wouldn't have thought that would be enough to cause python to fully scan the file system.

Revision history for this message
moimael (moimael) wrote :

So what's the best solution for you ? Solution 1 or 2 ? I think the 2 is the best one but not sure.

Changed in openshot:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Robin Clarke (irreire) wrote :

2. would work for me.

Andy Finch (fincha)
summary: - Scan of filesystem on startup?
+ Adding project file by drag & drop does not update import_folder xml
+ element
Revision history for this message
Andy Finch (fincha) wrote :

I've added a fix for this to the trunk. Now the import folder setting is updated if a file is dropped into OpenShot.

Changed in openshot:
status: Confirmed → Fix Committed
milestone: none → 1.4.3
Jonathan Thomas (jonoomph)
Changed in openshot:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.