elementary Icons

Rename "not-starred" to "non-starred"

Bug #925614 reported by Victor Martinez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
BeatBox
Fix Released
Low
Victor Martinez
BeatBox 1.0
elementary Icons
Fix Released
Undecided
Unassigned
elementary Icons 3.0

Bug Description

The star icons come in pairs named "starred" and "non-starred".
As elementary icons are using "not-starred", BeatBox cannot find that icon in other icon themes, and we end up using the "starred" icon from the user's icon theme and "not-starred" from fallback.

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

I'm looking here: http://standards.freedesktop.org/icon-naming-spec/latest/ and don't see any specs for starred, so it's difficult to know which is correct or "more" correct. Am I missing something?

Revision history for this message
Victor Martinez (victored) wrote :

elementary is using "starred-symbolic" and "non-starred-symbolic", just like GNOME's icon theme. However, it breaks the rule in non-symbolic variations.

This is causing an odd bug in BeatBox because we use the "starred" icon from the user's icon theme and "not-starred" from our fallback mode (since the complimentary icon was named "non-starred" in the icon theme).

Revision history for this message
Danielle Foré (danrabbit) wrote :

fixed in icons. Now using "non-starred" for both the symbolic and colored variants.

Changed in elementaryicons:
status: New → Fix Committed
Cris Dywan (kalikiana)
Changed in postler:
status: New → Confirmed
Revision history for this message
Victor Martinez (victored) wrote :

Thanks a lot Daniel

Changed in beat-box:
assignee: nobody → Victor Eduardo (victored)
importance: Undecided → Low
milestone: none → 1.0
status: New → In Progress
Victor Martinez (victored)
Changed in beat-box:
status: In Progress → Fix Committed
Victor Martinez (victored)
Changed in beat-box:
status: Fix Committed → Fix Released
Danielle Foré (danrabbit)
Changed in elementaryicons:
milestone: none → 3.0
Sergey "Shnatsel" Davidoff (shnatsel)
Changed in elementaryicons:
status: Fix Committed → Fix Released
Revision history for this message
Cody Garver (codygarver) wrote :

I want this bug to die and I don't have permission to kill it, so I submitted a branch to fix it.

Danielle Foré (danrabbit)
no longer affects: postler
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.