The color box around patron name dissappears when a user note is created.

Bug #921817 reported by Steve Callender
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
2.1
Fix Released
Undecided
Unassigned
2.2
Fix Released
Undecided
Unassigned

Bug Description

When going into a patron account, if you place a note on the account by means of the Message > Apply Standing Penalty/Message button, than the colored box that typically encloses the patron name on the top left of the screen goes away. It appears there is no style settings in the patron display css for this. In my opinion, it should at least make a yellow box to match the "Alerts" css.

This has been tested in 2.0 and 2.1. In 2.0 it looks like even if there is a penalty on the account, placing a note will remove the colored box that was created from the penalty.

In 2.1 it appears to only happen when there is no other penalty on the account.

Tags: pullrequest
Revision history for this message
Jason Etheridge (phasefx) wrote :

If you look under Admin -> Local Administration -> Standing Penalties, you'll see a list of penalties defined in the system. The value in the "name" column for these gets re-used as CSS classnames in the patron display.

For example, in server/skin/patron_display.css, there is the line:
.PATRON_EXCEEDS_CHECKOUT_COUNT .patronNameLarge { border: solid thick #C99DFF; padding: 10px; }

This corresponds with the penalty PATRON_EXCEEDS_CHECKOUT_COUNT and is responsible for coloring a border around the patron's name when they have that penalty.

There are also similar CSS classnames that get used in the same way, such as one for NO_PENALTY, ONE_PENALTY, and MULTIPLE_PENALTIES. The NO_PENALTY one produces the green border.

The stock penalties that get used by radio buttons in the Apply New Standing Penalty dialog are SILENT_NOTE, ALERT_NOTE, and STAFF_CHR (the CHR stands for Circs, Holds, and Renewals). Custom penalties show up in the drop-down menu in the upper right, and they'll use whatever values you give them for their "name" field.

So, to handle this bug, I think we need CSS for ALERT_NOTE and STAFF_CHR, and maybe for ONE_PENALTY and MULTIPLE_PENALTIES (to be a default catch-all for custom penalties).

For example:
.STAFF_CHR .patronNameLarge { border: solid thick red; padding: 10px; }

If someone would like to experiment with colors here (you can create a server/skin/patron_display_custom.css file to do this), and propose some stock CSS for these penalties, I'll be happy to push a branch with the changes.

Revision history for this message
Michael Peters (mrpeters) wrote :

Created new entries for the cases Jason recommended.

user/mrpeters-isl/addl_patron_standing_css_rules
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=e184ac7f5b96e9ae143af8de2f54a3f753807af9

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Low
tags: added: pullrequest
Revision history for this message
Jason Etheridge (phasefx) wrote :

The changes here intersect some related commits that have happened since:

98d2995b1091cbaf982fd8e63ba53424512fddd5
7758ff50c14ae46724f41895dcaa184581755ae6

http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=98d2995b1091cbaf982fd8e63ba53424512fddd5
http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=7758ff50c14ae46724f41895dcaa184581755ae6

Penalties with the alert flag are now handled (though with blue, not yellow), however, a simple Note penalty can still result in no colors. So here's a new branch using Michael's colors for these non-alerting non-blocking penalties:

collab/phasefx/patron_css @ working/Evergreen.git
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/patron_css

Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Thanks Steve, Jason, and Mike! This works for me, and I've backported it through rel_2_1.

Lebbeous

Changed in evergreen:
status: Confirmed → Fix Committed
milestone: none → 2.3.0-beta1
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.