The color box around patron name dissappears when a user note is created.
Bug #921817 reported by
Steve Callender
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Low
|
Unassigned | ||
2.1 |
Fix Released
|
Undecided
|
Unassigned | ||
2.2 |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
When going into a patron account, if you place a note on the account by means of the Message > Apply Standing Penalty/Message button, than the colored box that typically encloses the patron name on the top left of the screen goes away. It appears there is no style settings in the patron display css for this. In my opinion, it should at least make a yellow box to match the "Alerts" css.
This has been tested in 2.0 and 2.1. In 2.0 it looks like even if there is a penalty on the account, placing a note will remove the colored box that was created from the penalty.
In 2.1 it appears to only happen when there is no other penalty on the account.
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
If you look under Admin -> Local Administration -> Standing Penalties, you'll see a list of penalties defined in the system. The value in the "name" column for these gets re-used as CSS classnames in the patron display.
For example, in server/ skin/patron_ display. css, there is the line: EXCEEDS_ CHECKOUT_ COUNT .patronNameLarge { border: solid thick #C99DFF; padding: 10px; }
.PATRON_
This corresponds with the penalty PATRON_ EXCEEDS_ CHECKOUT_ COUNT and is responsible for coloring a border around the patron's name when they have that penalty.
There are also similar CSS classnames that get used in the same way, such as one for NO_PENALTY, ONE_PENALTY, and MULTIPLE_PENALTIES. The NO_PENALTY one produces the green border.
The stock penalties that get used by radio buttons in the Apply New Standing Penalty dialog are SILENT_NOTE, ALERT_NOTE, and STAFF_CHR (the CHR stands for Circs, Holds, and Renewals). Custom penalties show up in the drop-down menu in the upper right, and they'll use whatever values you give them for their "name" field.
So, to handle this bug, I think we need CSS for ALERT_NOTE and STAFF_CHR, and maybe for ONE_PENALTY and MULTIPLE_PENALTIES (to be a default catch-all for custom penalties).
For example:
.STAFF_CHR .patronNameLarge { border: solid thick red; padding: 10px; }
If someone would like to experiment with colors here (you can create a server/ skin/patron_ display_ custom. css file to do this), and propose some stock CSS for these penalties, I'll be happy to push a branch with the changes.