External sites can be opened in the staff client

Bug #921740 reported by Thomas Berezansky
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.1
Won't Fix
Undecided
Unassigned
2.2
Fix Released
Undecided
Unassigned

Bug Description

The branch below fixes this in two ways:

1 - It adds a new open_external function for use by things like the portal page. This will open links in the user's default browser regardless of where they point to.

2 - It adds a component that implements the content-policy routines to intercept loads of pages. If they go to a http/https domain that the user is not currently logged into then the load is stopped and the default browser is opened instead.

I am unsure if this should be considered a security fix and thus backported as far back as it will go.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/open_external

Changed in evergreen:
status: New → In Progress
Changed in evergreen:
status: In Progress → New
Revision history for this message
Michael Peters (mrpeters) wrote :

Tested as best I could, seems to work as advertised. Always good to close a potential security hole.

user/mrpeters-isl/open_external_signoff
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrpeters-isl/open_external_signoff

tags: added: signedoff
Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
milestone: none → 2.3.0-beta1
Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Tested this. It works, and it's now in master and rel_2_2. Do we want this for rel_2_1? It didn't merge cleanly for me, but I haven't gone into how much tweaking it would take. May or may not be a lot.

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.