CollectionAssert.IsNotEmpty must dispose Enumerator

Bug #920472 reported by pil0t
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
NUnit Framework
Fix Released
Low
Charlie Poole
NUnit V2
Fix Released
Low
Charlie Poole

Bug Description

    protected static bool IsEmpty(IEnumerable enumerable)
    {
      ICollection collection = enumerable as ICollection;
      if (collection != null)
        return collection.Count == 0;
      else
        return !enumerable.GetEnumerator().MoveNext();
    }

enumerable.GetEnumerator() - is not disposed

Changed in nunitv2:
status: New → Triaged
importance: Undecided → Low
Changed in nunit-3.0:
status: New → Triaged
importance: Undecided → Low
Changed in nunitv2:
assignee: nobody → Charlie Poole (charlie.poole)
Changed in nunit-3.0:
assignee: nobody → Charlie Poole (charlie.poole)
milestone: none → 2.9.6
Changed in nunitv2:
status: Triaged → Fix Committed
Changed in nunit-3.0:
status: Triaged → Fix Committed
Changed in nunitv2:
milestone: none → 2.6.0rc
Changed in nunitv2:
status: Fix Committed → Fix Released
Changed in nunit-3.0:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.