AttributeError: 'CommitDialog' object has no attribute '_last_selected_file'

Bug #919993 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar GTK+ Frontends
Fix Released
High
Curtis Hovey

Bug Description

I occasionally see the following traceback when committing use bzr-gtk r769 on precise:

  File "/home/curtis/.bazaar/plugins/gtk/commit.py", line 579, in _on_treeview_files_cursor_changed
    self._update_per_file_info(selection)
  File "/home/curtis/.bazaar/plugins/gtk/commit.py", line 618, in _update_per_file_info
    self._save_current_file_message()
  File "/home/curtis/.bazaar/plugins/gtk/commit.py", line 605, in _save_current_file_message
    if self._last_selected_file is None:
AttributeError: 'CommitDialog' object has no attribute '_last_selected_file'

The commit is successful. Looking at the order of events,
_construct_file_list() connects _on_treeview_files_cursor_changed() to the cursor-changed signal.
_on_treeview_files_cursor_changed() presumes _last_selected_file() was created,
but it will not be created until _fill_in_per_file_info() is called (which is two lines before _construct_file_list())

The cursor-changed signal may have been called after _fill_in_per_file_info(), but it is often called before with
Gtk3.

Tags: precise

Related branches

Curtis Hovey (sinzui)
Changed in bzr-gtk:
assignee: nobody → Curtis Hovey (sinzui)
status: New → In Progress
Curtis Hovey (sinzui)
Changed in bzr-gtk:
importance: Undecided → High
milestone: none → 0.104.0
Curtis Hovey (sinzui)
Changed in bzr-gtk:
status: In Progress → Fix Committed
Jelmer Vernooij (jelmer)
Changed in bzr-gtk:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.