uncomfortable include/libtnt structure

Bug #912003 reported by rowdyro
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tarantool
Fix Released
Medium
Dmitry Simonenko

Bug Description

OS: FreeBSD 8.2-RELEASE x86
GCC: 4.2.1
Build: tarantool-1.4.4-99-g4ab679d-freebsd-i386.tar.gz

If we put libtnt directory in, for example, /usr/local/include

and in our c/c++ program we include it us

#include <libtnt/tnt.h>

but, what we see in libtnt/tnt.h:

#include <tnt_mem.h>
#include <tnt_proto.h>
#include <tnt_enc.h>
#include <tnt_tuple.h>
#include <tnt_reply.h>
#include <tnt_stream.h>
#include <tnt_iter.h>
#include <tnt_buf.h>
#include <tnt_ping.h>
#include <tnt_insert.h>
#include <tnt_update.h>
#include <tnt_delete.h>
#include <tnt_call.h>
#include <tnt_select.h>

so files will be search in /usr/local/include - and we'll have
error: tnt_mem.h: No such file or directory
...
...

I think the right way is make includes with "...".

Also, why some files are not included in tnt.h? for example, tnt_net.h.

Thanks

Kostja Osipov (kostja)
Changed in tarantool:
assignee: nobody → Dmitry Simonenko (pmwkaa)
milestone: none → 1.4.5
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Dmitry Simonenko (pmwkaa) wrote :

Fixed on branch connector-c-include.

tnt_net.h and tnt_sql.h are not include in tnt.h, because they are separate libraries and can be installed separately. (libtnt is buffer oriented library, and it doesn't depend on libtntnet and libtntsql, etc).

Changed in tarantool:
status: Confirmed → Fix Committed
Kostja Osipov (kostja)
summary: - uncomfortable include/libmnt structure
+ uncomfortable include/libtnt structure
Kostja Osipov (kostja)
Changed in tarantool:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.