Per team/project charts are broken

We already have a failing test for this. If only we had something configured to run all tests on a daily basis, we'd have found this a bit earlier. :)

======================================================================
FAIL: test_get_patches_per_month_up_to (patchmetrics.tests.models.TestChartHelpers)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/salgado/devel/patchwork/apps/patchmetrics/tests/models.py", line 142, in test_get_patches_per_month_up_to
    self.assertEqual([(last_month.month, 1), (now.month, 2)], submitted)
AssertionError: Lists differ: [(12, 1), (1, 2)] != []

First list contains 2 additional elements.
First extra element 0:
(12, 1)

- [(12, 1), (1, 2)]
+ []

Here's the fix: http://git.linaro.org/gitweb?p=people/salgado/patchwork.git;a=commitdiff;h=133c581ec80e97642e7e24acdd5ba8b34b4a5243

Actually, the one above is for another bug. Here's the actual fix for this:

http://git.linaro.org/gitweb?p=people/salgado/patchwork.git;a=commitdiff;h=b90b04956faa48a637b1b976da00071c7b14e400

Looks good. We really need to set up pre-commit hooks running tests automatically (or at least periodically).

Actually, wasn't the previous code checking including the entire current month (i.e. <= (year, month)), and this one doesn't (except for the first of the month)? Am I misreading it, though?

On Wed, 2012-01-04 at 16:41 +0000, Данило Шеган wrote:
> Actually, wasn't the previous code checking including the entire current
> month (i.e. <= (year, month)), and this one doesn't (except for the
> first of the month)? Am I misreading it, though?

I think what you were missing is the fact that start_date will always be
the first second of the first day of a given month (because we want the
metrics for patches submitted between the first and last seconds of the
month). Either that or I misunderstood your question.