wspinny rapidly fast forwards track when clicked
Bug #879720 reported by
Owen Williams
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
Fix Released
|
High
|
RJ Skerry-Ryan | ||
Bug Description
When clicking the WSpinny widget to initiate a scratch, the playhead zooms forward along the track. This is due to a new bug:
m_dPrevTheta is calculated as a simple -180 to 180 value, but m_iFullRotations is set based on the absolute position in the track. When the widget is clicked, wspinny calculates the difference between the "old" position (-180 to 180) and the "new" position which could be many many full rotations down the way. So this causes a massive forward seek.
possible solution: initialize m_dPrevTheta to include full rotations
Revision history for this message
| Owen Williams (ywwg) wrote | #1 |
Revision history for this message
| RJ Skerry-Ryan (rryan) wrote | #2 |
| Changed in mixxx: | |
| status: | New → Fix Committed |
| importance: | Undecided → High |
| assignee: | nobody → RJ Ryan (rryan) |
| milestone: | none → 1.10.0 |
| Changed in mixxx: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Swiftb0y (swiftb0y) wrote | #3 |
| lock status: | Metadata changes locked and limited to project staff |
To post a comment you must log in.
there are also some instances where wspinny is not correcting for stereo audio, and these need to be checked for correctness