[Patch] Enter doesn't launch applications in gnome-shell zeitgeistsearch extension

Thanks a lot buddy. Good job :) will patch it :)

On Fri, Oct 21, 2011 at 1:15 AM, Mike Auty <email address hidden>wrote:

> ** Patch added: "Patch to include aliasing imports.misc.Params as Params"
>
> https://bugs.launchpad.net/bugs/879146/+attachment/2563650/+files/zeitgeistsearch.patch
>
> --
> You received this bug notification because you are subscribed to The
> Zeitgeist Project.
> https://bugs.launchpad.net/bugs/879146
>
> Title:
> [Patch] Enter doesn't launch applications in gnome-shell
> zeitgeistsearch extension
>
> Status in Zeitgeist Extensions:
> New
>
> Bug description:
> When using the ZeitgeistSearch gnome-shell extension, there is a
> silent error that occurs in activateResult for the App- and Settings-
> AsyncSearchProviders. This is due to a call to Params, which hasn't
> been defined. I've attached a patch which solves this particular
> problem by defining Params at the top of the file.
>
> I'm also working on gnome bug 662341 which is related, whereby adding
> results asynchronously means that they are never selected first in the
> list, so you can't simply start typing an application and press Enter
> to start it. By default, all the asynchronous providers return an
> empty list as initialResults, and gnome-shell doesn't update the
> selection when new results are added, meaning the search buttons (such
> as Wikipedia) are always selected by default. I don't know whether
> that's best handled in the extension or in gnome-shell, so please let
> me know if I should file a new bug here instead.
>
> If there's any other information I can provide, or tests I can run,
> please let me know...
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/zeitgeist-extensions/+bug/879146/+subscriptions
>

Lets try to fix the "selection" bug in the extensions first... Are you up to
that :P

On Fri, Oct 21, 2011 at 10:05 PM, Seif Lotfy <email address hidden> wrote:

> Thanks a lot buddy. Good job :) will patch it :)
>
> On Fri, Oct 21, 2011 at 1:15 AM, Mike Auty <email address hidden>wrote:
>
>> ** Patch added: "Patch to include aliasing imports.misc.Params as Params"
>>
>> https://bugs.launchpad.net/bugs/879146/+attachment/2563650/+files/zeitgeistsearch.patch
>>
>> --
>> You received this bug notification because you are subscribed to The
>> Zeitgeist Project.
>> https://bugs.launchpad.net/bugs/879146
>>
>> Title:
>> [Patch] Enter doesn't launch applications in gnome-shell
>> zeitgeistsearch extension
>>
>> Status in Zeitgeist Extensions:
>> New
>>
>> Bug description:
>> When using the ZeitgeistSearch gnome-shell extension, there is a
>> silent error that occurs in activateResult for the App- and Settings-
>> AsyncSearchProviders. This is due to a call to Params, which hasn't
>> been defined. I've attached a patch which solves this particular
>> problem by defining Params at the top of the file.
>>
>> I'm also working on gnome bug 662341 which is related, whereby adding
>> results asynchronously means that they are never selected first in the
>> list, so you can't simply start typing an application and press Enter
>> to start it. By default, all the asynchronous providers return an
>> empty list as initialResults, and gnome-shell doesn't update the
>> selection when new results are added, meaning the search buttons (such
>> as Wikipedia) are always selected by default. I don't know whether
>> that's best handled in the extension or in gnome-shell, so please let
>> me know if I should file a new bug here instead.
>>
>> If there's any other information I can provide, or tests I can run,
>> please let me know...
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/zeitgeist-extensions/+bug/879146/+subscriptions
>>
>
>

On 21/10/11 21:22, Seif Lotfy wrote:
> Lets try to fix the "selection" bug in the extensions first... Are you up to
> that :P

Errrr, we can try, but my Javascript's not up to speed (and tracking
down the Params issue was the first look I'd ever had at the gnome-shell
API)... 5:)

I already tried emitting the "search-completed" signal with an
appropriate set of additional results, but I wasn't sure the lists I was
handing back contained the right thing, and it didn't seem to affect the
selection.

I'm happy to test out any patches you may have for the extension, but I
wouldn't really know where to start making a fix on my own. Let me know
what you want to do next?

Mike 5:)

Its good to know you are up to test my extensions.. I am doing some changes
here Will tell you when done :)

On Fri, Oct 21, 2011 at 10:34 PM, Mike Auty <email address hidden>wrote:

> On 21/10/11 21:22, Seif Lotfy wrote:
> > Lets try to fix the "selection" bug in the extensions first... Are you up
> to
> > that :P
>
> Errrr, we can try, but my Javascript's not up to speed (and tracking
> down the Params issue was the first look I'd ever had at the gnome-shell
> API)... 5:)
>
> I already tried emitting the "search-completed" signal with an
> appropriate set of additional results, but I wasn't sure the lists I was
> handing back contained the right thing, and it didn't seem to affect the
> selection.
>
> I'm happy to test out any patches you may have for the extension, but I
> wouldn't really know where to start making a fix on my own. Let me know
> what you want to do next?
>
> Mike 5:)
>
> --
> You received this bug notification because you are subscribed to The
> Zeitgeist Project.
> https://bugs.launchpad.net/bugs/879146
>
> Title:
> [Patch] Enter doesn't launch applications in gnome-shell
> zeitgeistsearch extension
>
> Status in Zeitgeist Extensions:
> New
>
> Bug description:
> When using the ZeitgeistSearch gnome-shell extension, there is a
> silent error that occurs in activateResult for the App- and Settings-
> AsyncSearchProviders. This is due to a call to Params, which hasn't
> been defined. I've attached a patch which solves this particular
> problem by defining Params at the top of the file.
>
> I'm also working on gnome bug 662341 which is related, whereby adding
> results asynchronously means that they are never selected first in the
> list, so you can't simply start typing an application and press Enter
> to start it. By default, all the asynchronous providers return an
> empty list as initialResults, and gnome-shell doesn't update the
> selection when new results are added, meaning the search buttons (such
> as Wikipedia) are always selected by default. I don't know whether
> that's best handled in the extension or in gnome-shell, so please let
> me know if I should file a new bug here instead.
>
> If there's any other information I can provide, or tests I can run,
> please let me know...
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/zeitgeist-extensions/+bug/879146/+subscriptions
>